Patch the init container with compute resources #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @yonatankahana for review |
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #85 +/- ##
==========================================
+ Coverage 67.66% 68.07% +0.40%
==========================================
Files 6 6
Lines 838 855 +17
==========================================
+ Hits 567 582 +15
- Misses 234 236 +2
Partials 37 37
☔ View full report in Codecov by Sentry. |
feizhe1996
force-pushed
the
patch_compute_resources
branch
2 times, most recently
from
620f1fc
to
8d7d8c3
Compare
yonatankahana
requested changes
Oct 12, 2023
|
ping @feizhe1996 |
Ack |
feizhe1996
force-pushed
the
patch_compute_resources
branch
from
8d7d8c3
to
e8125ab
Compare
|
Ping @yonatankahana for review |
feizhe1996
force-pushed
the
patch_compute_resources
branch
2 times, most recently
from
bdf5805
to
31b9d48
Compare
Fix for k8tz#83. Previously, the compute resources specified in values.yaml did not get passed down to the initContainer specs. When the namespace is guarded by a resource quota, each container needs to specify the resource requirement, otherwise, k8s throws quota errors. Since the resources definition is a multi-line string block, the fix tries to pass a json formatted string as an argument to the cli.
feizhe1996
force-pushed
the
patch_compute_resources
branch
from
31b9d48
to
0e4a7a4
Compare
|
ping @yonatankahana for review |
|
we are still waiting for mr |
ping @yonatankahana again |
yonatankahana
requested changes
May 31, 2024
feizhe1996
force-pushed
the
patch_compute_resources
branch
2 times, most recently
from
472d0a5
to
9b7148a
Compare
…ontainerResources param in helm chart's readme
feizhe1996
force-pushed
the
patch_compute_resources
branch
from
9b7148a
to
e86f27b
Compare
|
Commit updated cc: @yonatankahana |
kireque
pushed a commit
to kireque/home-ops
that referenced
this pull request
Jun 1, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [k8tz](http://k8tz.io) ([source](https://togithub.com/k8tz/k8tz)) | patch | `0.16.0` -> `0.16.1` | --- ### Release Notes <details> <summary>k8tz/k8tz (k8tz)</summary> ### [`v0.16.1`](https://togithub.com/k8tz/k8tz/blob/HEAD/CHANGELOG.md#0161) - Add possibility to set init container resources ([k8tz/k8tz#85) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM4NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9wYXRjaCJdfQ==--> Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #83.
Previously, the compute resources specified in values.yaml did not get passed down to the initContainer specs. When the namespace is guarded by a resource quota, each container needs to specify the resource requirement, otherwise, k8s throws quota errors.
Since the resources definition is a multi-line string block, the fix tries to pass a json formatted string as an argument to the cli.