-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch the init container with compute resources #85
Conversation
cc: @yonatankahana for review |
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #85 +/- ##
==========================================
+ Coverage 67.66% 68.07% +0.40%
==========================================
Files 6 6
Lines 838 855 +17
==========================================
+ Hits 567 582 +15
- Misses 234 236 +2
Partials 37 37
☔ View full report in Codecov by Sentry. |
620f1fc
to
8d7d8c3
Compare
ping @feizhe1996 |
Ack |
8d7d8c3
to
e8125ab
Compare
Ping @yonatankahana for review |
bdf5805
to
31b9d48
Compare
Fix for k8tz#83. Previously, the compute resources specified in values.yaml did not get passed down to the initContainer specs. When the namespace is guarded by a resource quota, each container needs to specify the resource requirement, otherwise, k8s throws quota errors. Since the resources definition is a multi-line string block, the fix tries to pass a json formatted string as an argument to the cli.
31b9d48
to
0e4a7a4
Compare
ping @yonatankahana for review |
we are still waiting for mr |
ping @yonatankahana again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi, sorry for my late responses. please fix this small things and let's release it this weekend.
472d0a5
to
9b7148a
Compare
…ontainerResources param in helm chart's readme
9b7148a
to
e86f27b
Compare
Commit updated cc: @yonatankahana |
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [k8tz](http://k8tz.io) ([source](https://togithub.com/k8tz/k8tz)) | patch | `0.16.0` -> `0.16.1` | --- ### Release Notes <details> <summary>k8tz/k8tz (k8tz)</summary> ### [`v0.16.1`](https://togithub.com/k8tz/k8tz/blob/HEAD/CHANGELOG.md#0161) - Add possibility to set init container resources ([k8tz/k8tz#85) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM4NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9wYXRjaCJdfQ==--> Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
Fix for #83.
Previously, the compute resources specified in values.yaml did not get passed down to the initContainer specs. When the namespace is guarded by a resource quota, each container needs to specify the resource requirement, otherwise, k8s throws quota errors.
Since the resources definition is a multi-line string block, the fix tries to pass a json formatted string as an argument to the cli.