Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(helm): Add possibility to set topologySpreadConstraints to k8tz controller #90

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

bastienbosser
Copy link

I need to add this feature to the k8tz helm chart:

  • Add possibility to set topologySpreadConstraints to k8tz controller

As you know, topology spread constraints are used to control how pods are spread across your cluster among failure-domains such as regions, zones, nodes, and other user-defined topology domains. This can help to achieve high availability as well as efficient resource utilization.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fdbd542) 67.66% compared to head (5f7b345) 67.66%.

❗ Current head 5f7b345 differs from pull request most recent head 585bcdd. Consider uploading reports for the commit 585bcdd to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   67.66%   67.66%           
=======================================
  Files           6        6           
  Lines         838      838           
=======================================
  Hits          567      567           
  Misses        234      234           
  Partials       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yonatankahana yonatankahana merged commit 749a05c into k8tz:master Dec 3, 2023
3 checks passed
@yonatankahana yonatankahana self-assigned this Dec 3, 2023
@bastienbosser
Copy link
Author

Hello @yonatankahana,
Would it be possible for you to create a new release of helm chart k8tz that embeds this feature, please?

@yonatankahana
Copy link
Member

yonatankahana commented Dec 22, 2023

@bastienbosser
yes, the changes released as part of version 0.14.1.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants