Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(helm): allow using helm built-in namespace #92

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

yonatankahana
Copy link
Member

@yonatankahana yonatankahana commented Dec 12, 2023

The change is fully backward compatible and allows the user to decide whether he uses the namespace from the values.yaml or the built-in namespace of helm (--namespace).
The change is made possible thanks to the ability to exclude namespaces by name and not only by annotation as was the case until PR #79.

Now you can set the namespace to null and use the built-in namespace, i.e:

helm install k8tz k8tz/k8tz --namespace=myothernamespace --create-namespace --set namespace=

The namespace in the values can be still used with existing namespace by setting createNamespace to false, i.e:

helm install k8tz k8tz/k8tz --set namespace=existingnamespace --set createNamespace=false

And in the future if we want, we can always make breaking changes by removing namespace completely from values.

Fix #91

@codecov-commenter

This comment was marked as off-topic.

@yonatankahana yonatankahana force-pushed the fix-namespace branch 2 times, most recently from 1f4d1c5 to 0fd87bb Compare December 22, 2023 09:46
@yonatankahana yonatankahana marked this pull request as ready for review December 22, 2023 09:47
@yonatankahana yonatankahana added enhancement New feature or request area/helm Helm chart area labels Dec 22, 2023
@yonatankahana yonatankahana merged commit ed700b9 into k8tz:master Dec 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Helm chart area enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to deploy helm chart to existing namespace
2 participants