refactor(helm): allow using helm built-in namespace #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is fully backward compatible and allows the user to decide whether he uses the namespace from the values.yaml or the built-in namespace of helm (
--namespace
).The change is made possible thanks to the ability to exclude namespaces by name and not only by annotation as was the case until PR #79.
Now you can set the namespace to null and use the built-in namespace, i.e:
helm install k8tz k8tz/k8tz --namespace=myothernamespace --create-namespace --set namespace=
The
namespace
in the values can be still used with existing namespace by settingcreateNamespace
to false, i.e:helm install k8tz k8tz/k8tz --set namespace=existingnamespace --set createNamespace=false
And in the future if we want, we can always make breaking changes by removing
namespace
completely from values.Fix #91