Skip to content

Commit

Permalink
Add update permission to the chart for roles
Browse files Browse the repository at this point in the history
Without this role, people who migrate from 2.6 to 2.7 can run into
issues with updating roles in the namespaces.

Fixes: #834
Signed-off-by: Simon Beck <simon.beck@vshn.ch>
  • Loading branch information
Kidswiss committed Apr 14, 2023
1 parent af2bcaf commit be30b77
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 5 deletions.
2 changes: 1 addition & 1 deletion charts/k8up/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ keywords:
- backup
- operator
- restic
version: 4.2.0
version: 4.2.1
sources:
- https://github.com/k8up-io/k8up
maintainers:
Expand Down
4 changes: 2 additions & 2 deletions charts/k8up/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# k8up

![Version: 4.2.0](https://img.shields.io/badge/Version-4.2.0-informational?style=flat-square)
![Version: 4.2.1](https://img.shields.io/badge/Version-4.2.1-informational?style=flat-square)

Kubernetes and OpenShift Backup Operator based on restic

Expand All @@ -13,7 +13,7 @@ helm repo add k8up-io https://k8up-io.github.io/k8up
helm install k8up k8up-io/k8up
```
```bash
kubectl apply -f https://github.com/k8up-io/k8up/releases/download/k8up-4.2.0/k8up-crd.yaml
kubectl apply -f https://github.com/k8up-io/k8up/releases/download/k8up-4.2.1/k8up-crd.yaml
```

<!---
Expand Down
1 change: 1 addition & 0 deletions charts/k8up/templates/operator-clusterrole.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -281,5 +281,6 @@ rules:
- delete
- get
- list
- update
- watch
{{- end -}}
1 change: 1 addition & 0 deletions config/rbac/role.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -279,4 +279,5 @@ rules:
- delete
- get
- list
- update
- watch
4 changes: 2 additions & 2 deletions operator/backupcontroller/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
k8upv1 "github.com/k8up-io/k8up/v2/api/v1"
"github.com/k8up-io/k8up/v2/operator/reconciler"
batchv1 "k8s.io/api/batch/v1"
"sigs.k8s.io/controller-runtime"
controllerruntime "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/predicate"
)

Expand All @@ -19,7 +19,7 @@ import (
// +kubebuilder:rbac:groups=core,resources=serviceaccounts,verbs=get;list;watch;create;delete
// +kubebuilder:rbac:groups=core,resources=persistentvolumeclaims,verbs=get;list;watch
// +kubebuilder:rbac:groups=core,resources=persistentvolumes,verbs=get;list;watch
// +kubebuilder:rbac:groups=rbac.authorization.k8s.io,resources=roles;rolebindings,verbs=get;list;watch;create;delete
// +kubebuilder:rbac:groups=rbac.authorization.k8s.io,resources=roles;rolebindings,verbs=get;list;watch;create;delete;update

// SetupWithManager configures the reconciler.
func SetupWithManager(mgr controllerruntime.Manager) error {
Expand Down

0 comments on commit be30b77

Please sign in to comment.