Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New configuration concept #121

Open
Kidswiss opened this issue Oct 27, 2020 · 0 comments
Open

New configuration concept #121

Kidswiss opened this issue Oct 27, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@Kidswiss
Copy link
Contributor

Kidswiss commented Oct 27, 2020

Summary

As a user
I want to have composable configuration
So that so I can re-use defaults and repository configs

Context

Currently, defaults for backups can be defined by setting environment variables. While this serves its purpose, it's not very flexible and rather cumbersome to configure.

So I propose a new way to configure and schedule backups. We should split the configuration:

  • repository: contains information about the repository. Credentials, bucketname, encryption password. etc.
  • schedule: takes a jobPlan and a repository and schedules the backups according to the given cron string.
  • jobPlan: contains information about what should get backed up. This can be PVCs and Pods with prebackup commands.

Out of Scope

Further Links

Acceptance Criteria

Given a `k8up.io/v2/Schedule` spec
When I refer a `k8up.io/v2/JobPlan` spec
Then K8up can spawn backups using the configuration provided in the `JobPlan` spec.
Given a `k8up.io/v2/JobPlan` spec
When I specify what PVCs I want backed up
Then K8up will only backup those PVCs
Given a `k8up.io/v2/JobPlan` spec
When I specify what pods I want for prebackup commands
Then K8up will only backup those pods via prebackup commands

Implementation Ideas

  • For PVC and Pod targeting we can use multiple things. Labels or regex for the names, or a mix of both.
@Kidswiss Kidswiss added the enhancement New feature or request label Oct 27, 2020
@tobru tobru added this to the Configuration Refactoring milestone Nov 26, 2020
@tobru tobru removed this from the vFuture milestone Dec 7, 2021
@tobru tobru added this to the K8up v3 milestone Jun 2, 2023
@tobru tobru removed this from the K8up v3 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Planned
Development

No branches or pull requests

2 participants