Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in env var BACKUP_GLOBALRESTORES3ACCESKEYID #141

Closed
mweibel opened this issue Nov 11, 2020 · 5 comments
Closed

typo in env var BACKUP_GLOBALRESTORES3ACCESKEYID #141

mweibel opened this issue Nov 11, 2020 · 5 comments

Comments

@mweibel
Copy link
Collaborator

mweibel commented Nov 11, 2020

There's an s missing in the Acces*s* part. Unsure what implications this has, but might be unpleasant 😄

@Kidswiss
Copy link
Contributor

🤦‍♂️

Well fixing that one would probably break a few operator configurations. But if we mark it in the changelog as a breaking change it should be fine.

@tobru tobru added this to the Configuration Refactoring milestone Nov 26, 2020
@tobru
Copy link
Contributor

tobru commented Nov 26, 2020

Won't do, will be fixed in #121

@Kidswiss
Copy link
Contributor

Kidswiss commented Nov 27, 2020

While testing I found that this typo doesn't seem to be in the legacy K8up releases. So we should fix it or we'll actually break backwards compatibility :D

Looks like #155 will fix it

@ccremer
Copy link
Contributor

ccremer commented Nov 30, 2020

@ccremer
Copy link
Contributor

ccremer commented Nov 30, 2020

This is fixed now in master, it was a documentation issue.
The config refactoring itself is in a separate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants