Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifi CLI of backup and restic modules of k8up #477

Closed
cimnine opened this issue Aug 12, 2021 · 0 comments · Fixed by #495
Closed

Unifi CLI of backup and restic modules of k8up #477

cimnine opened this issue Aug 12, 2021 · 0 comments · Fixed by #495
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@cimnine
Copy link
Contributor

cimnine commented Aug 12, 2021

Summary

As user of k8up
I want a stringent usage of the tool
So that I can reduce learning to a minimum.

Context

#359 moved the wrestic code into the k8up repository, but did try to changes as little as possible of the architecture.
The idea of this issue is to unify the command line interface of the two modules, operator and restic.

Currently, the two modules have different concepts to deal with arguments and variables. While the operator module is mostly relying on environment variables, the restic module mostly relies on command line arguments.

One unified approach could be that for every argument, both are possible: CLI argument and environment variable.

Out of Scope

  • Changes to the functionality.

Further links

Acceptance criteria

  • Given k8up help, when looking through the available commands and arguments, the two modules seem to have been developed with the same usage concepts in mind.

Implementation Ideas

The cli library in use already supports environment variables for CLI arguments. This could be leveraged to unifi the command line interface of the two modules.

If this change is not backwards compatible, make sure to adjust the relevant documentation, code parts, configuration examples, default configuration values, etc.

@cimnine cimnine added the enhancement New feature or request label Aug 12, 2021
@tobru tobru added this to the Wrestic Integration milestone Aug 12, 2021
@cimnine cimnine mentioned this issue Aug 16, 2021
11 tasks
@cimnine cimnine self-assigned this Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants