Unified Command Line Interface #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cimnine
force-pushed
the
UnifiedCommandLineInterface
branch
from
8bce443
to
1793308
Compare
cimnine
force-pushed
the
UnifiedCommandLineInterface
branch
7 times, most recently
from
0b64586
to
c3a5b8b
Compare
Previously, the code was clustered with os.GetEnv and os.LookupEnv calls. Not there is a central source and the configuration is built when the program starts. The configuration can be checked when the program starts, adhering to the 'Fail Fast' principle.
cimnine
force-pushed
the
UnifiedCommandLineInterface
branch
from
c3a5b8b
to
ae876cf
Compare
cimnine
force-pushed
the
UnifiedCommandLineInterface
branch
from
892204a
to
800f636
Compare
cimnine
force-pushed
the
UnifiedCommandLineInterface
branch
2 times, most recently
from
bb4ba8e
to
630443b
Compare
ccremer
reviewed
Sep 10, 2021
And add support for --keep-within-*
cimnine
force-pushed
the
UnifiedCommandLineInterface
branch
from
630443b
to
d534021
Compare
ccremer
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Both modules (restic and operator) are now configured via
urfave/cli's Flags. All the flags' values can be still be defined via their respective ENV variables.The advantage is that both modules build upon the same mechanism to configuration. Also
urface/clidoes some basic parsing and it has built-in support for required arguments / ENV vars.Finally, it reduces one dependency.
Closes #477
Checklist
bug,enhancement,documentation,change,breaking,as they show up in the changelog