Add update permission to the chart for roles #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kidswiss
requested review from
tobru and
lieneluksika
and removed request for
a team
Kidswiss
force-pushed
the
fix/role_permissions
branch
2 times, most recently
from
12b5e97
to
abbba0f
Compare
Kidswiss
requested review from
glrf and
wejdross
and removed request for
tobru and
lieneluksika
Without this role, people who migrate from 2.6 to 2.7 can run into issues with updating roles in the namespaces. Fixes: #834 Signed-off-by: Simon Beck <simon.beck@vshn.ch>
Kidswiss
force-pushed
the
fix/role_permissions
branch
from
abbba0f
to
be30b77
Compare
wejdross
approved these changes
Apr 14, 2023
glrf
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Without this permission, people who migrate from 2.6 to 2.7 can run into issues with updating roles in the namespaces.
Fixes: #834
Checklist
For Helm Chart changes
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog
area:chartchart:k8upmake chart-docs