Separate e2e tests and KIND from main Makefile #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a preparation step on the way to extract E2E-related code into it's own Makefile, if possible.
ccremer
reviewed
Jan 4, 2021
There was a problem hiding this comment.
I would propose to introduce lower-case variables for "make internal" variables, not necessary intended to be edited by developers (e.g. $(KIND_BIN) to $(kind_bin). Additionally, I'd propose to create a Makevariables.mk file, to be included with include Makevariables.mk at the top of Makefile. This variables file contains only the stuff to be edited by developer or per project (e.g. docker image names etc), so that the main makefile becomes easier to port to other repositories, and indicates better which variables are meant to be customized.
cimnine
force-pushed
the
198MakefileCleanup
branch
3 times, most recently
from
860b3e1
to
b683c7f
Compare
ccremer
approved these changes
Jan 5, 2021
ccremer
changed the title
Most of the targets – or at least their logic – were extracted to e2e/kind.mk and e2e/Makefile. Most variables were extracted into Makefile.vars.mk
cimnine
force-pushed
the
198MakefileCleanup
branch
from
b683c7f
to
6ed4b90
Compare
ccremer
approved these changes
Jan 5, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Re-organized the Makefile with regards to #198 .
Left to do:
./Makefileinto another fileChecklist
bug,enhancement,documentation,change,breaking,as they show up in the changelog
Update tests.