Fix Check Job Creation escapade #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccremer
approved these changes
Jan 8, 2021
cimnine
force-pushed
the
256PassBackendConfig
branch
from
03cc117
to
129be30
Compare
cimnine
force-pushed
the
256CreateThemAll
branch
from
272a50c
to
21fad10
Compare
|
Rebased to include latest changes from #260 |
3 tasks
cimnine
force-pushed
the
256PassBackendConfig
branch
from
129be30
to
f6962b7
Compare
cimnine
force-pushed
the
256CreateThemAll
branch
from
21fad10
to
993e85b
Compare
cimnine
force-pushed
the
256PassBackendConfig
branch
from
f6962b7
to
c07ebec
Compare
cimnine
force-pushed
the
256CreateThemAll
branch
from
993e85b
to
d73a716
Compare
This fix is implemented on two levels: First, when the Check handler tries to create a job and it exists, it will not attemp to schedule the job again. Second, it actually sets the Status.Started property on a Check resource once the job is scheduled, which prevents jobs to be created a second time in the first place.
cimnine
force-pushed
the
256CreateThemAll
branch
from
d73a716
to
07e4fa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Besides two refactoring (which are their own commits and which I could extract into their own PR if needed), this PR aims to fix that a lot of
Checkjobs are created and scheduled, even though they already exist, rsp. have been scheduled before.The culprit I have identified was that the
Check.Status.Startedproperty was never set. But it's that property which the check handler uses to determine whether it should create & schedule another check job.The logic of the Check handler was adjusted to match the logic of the other handlers in that regard.
This PR is part of the investigations of #256 and is based on #260. Fixes #257 .
Checklist
bug,enhancement,documentation,change,breaking,as they show up in the changelog
Update the documentation.