Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve failure handling in GH e2e report workflow #275

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Improve failure handling in GH e2e report workflow #275

merged 1 commit into from
Jan 11, 2021

Conversation

ccremer
Copy link
Contributor

@ccremer ccremer commented Jan 11, 2021 •
edited

Summary

There is a failure() conditional for workflow steps, let's use that instead of || true

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking,
    as they show up in the changelog

@ccremer ccremer added the change Generic change that is neither a fix or feature label Jan 11, 2021
@ccremer ccremer added this to the v1.0.0-rc3 milestone Jan 11, 2021
@ccremer ccremer marked this pull request as ready for review January 11, 2021 14:58
@ccremer
Improve failure handling in GH e2e report workflow
373e030 
There is a failuer() conditional for workflow steps, let's use that instead of || true
@ccremer ccremer merged commit 2b82056 into master Jan 11, 2021
@ccremer ccremer deleted the e2e-report branch January 11, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cimnine cimnine cimnine approved these changes

@Kidswiss Kidswiss Awaiting requested review from Kidswiss

Assignees
No one assigned
Labels
change Generic change that is neither a fix or feature
Projects
None yet
Milestone
v1.0.0-rc3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ccremer @cimnine