Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade of Operator SDK to 1.3.0 / Kubebuilder to v3 #283

Merged
merged 3 commits into from
Jan 15, 2021

Conversation

cimnine
Copy link
Contributor

@cimnine cimnine commented Jan 12, 2021

Summary

Applied the following advice:

Fixes #235

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking,
    as they show up in the changelog
  • Update the documentation.
  • Update tests.
  • Link this PR to related issues.

@cimnine cimnine added the enhancement New feature or request label Jan 12, 2021
@cimnine cimnine requested a review from ccremer January 12, 2021 16:21
@ccremer
Copy link
Contributor

ccremer commented Jan 12, 2021

According to Kubebuilder migration guide, we can also remove this bit from leader_election_role.yaml:

  resources:
  - configmaps/status
  verbs:
  - get
  - update
  - patch

@ccremer
Copy link
Contributor

ccremer commented Jan 13, 2021

So, related to #281 , I tried whether upgrading to controller-runtime to 0.7 will resolve the issue linked. It did not, but I've discovered other findings related to the upgrade.

I made a separate commit for it, but maybe it's probably best to upgrade this in a separate PR, because of the findings that we first should discuss.

@ccremer
Copy link
Contributor

ccremer commented Jan 13, 2021

Opened discussion here: #288

@cimnine
Copy link
Contributor Author

cimnine commented Jan 15, 2021

According to Kubebuilder migration guide, we can also remove this bit from leader_election_role.yaml:

This will become irrelevant when #289 is merged and when I've rebased, right? Please ignore.

@cimnine cimnine force-pushed the 235UpgradeOperatorSDK branch 2 times, most recently from bd1a330 to 3e94771 Compare January 15, 2021 10:25
@cimnine
Copy link
Contributor Author

cimnine commented Jan 15, 2021

Rebased onto master

@ccremer
Copy link
Contributor

ccremer commented Jan 15, 2021

I think you can remove my commit about upgrading the controller runtime. This should go into its own PR, e.g. #293 . this was for a test, but I can cherry-pick the commit locally to the other branch. Upgrading to 0.7 or 0.8 is also a K8s upgrade, so it's a big enough change to justify its own PR

@cimnine cimnine added this to the v1.0.0-rc4 milestone Jan 15, 2021
@cimnine cimnine merged commit f158cd5 into master Jan 15, 2021
@cimnine cimnine deleted the 235UpgradeOperatorSDK branch January 15, 2021 16:00
@ccremer ccremer added dependency Depedency update and removed enhancement New feature or request labels Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Depedency update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Upgrade Operator SDK to v1.3.x
2 participants