-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade of Operator SDK to 1.3.0 / Kubebuilder to v3 #283
Conversation
According to Kubebuilder migration guide, we can also remove this bit from leader_election_role.yaml: resources:
- configmaps/status
verbs:
- get
- update
- patch |
So, related to #281 , I tried whether upgrading to controller-runtime to 0.7 will resolve the issue linked. It did not, but I've discovered other findings related to the upgrade. I made a separate commit for it, but maybe it's probably best to upgrade this in a separate PR, because of the findings that we first should discuss. |
Opened discussion here: #288 |
|
bd1a330
to
3e94771
Compare
Rebased onto master |
3e94771
to
b0d39ba
Compare
I think you can remove my commit about upgrading the controller runtime. This should go into its own PR, e.g. #293 . this was for a test, but I can cherry-pick the commit locally to the other branch. Upgrading to 0.7 or 0.8 is also a K8s upgrade, so it's a big enough change to justify its own PR |
b0d39ba
to
b2d18e6
Compare
Summary
Applied the following advice:
Fixes #235
Checklist
bug
,enhancement
,documentation
,change
,breaking
,as they show up in the changelog