Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a test for mergeBackendWithDefaults #298

Merged
merged 2 commits into from
Jan 18, 2021
Merged

Adds a test for mergeBackendWithDefaults #298

merged 2 commits into from
Jan 18, 2021

Conversation

cimnine
Copy link
Contributor

@cimnine cimnine commented Jan 15, 2021

Summary

Adds a test for mergeBackendWithDefaults

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking,
    as they show up in the changelog
  • Update the documentation.
  • Update tests.
  • Link this PR to related issues.

@cimnine cimnine added the change Generic change that is neither a fix or feature label Jan 15, 2021
@cimnine cimnine requested a review from ccremer January 15, 2021 16:31
@cimnine cimnine force-pushed the TestMergeBackendWithDefaults branch from a7b5af1 to fe1dd37 Compare January 15, 2021 16:36
@cimnine cimnine self-assigned this Jan 18, 2021
ccremer
ccremer reviewed Jan 18, 2021
View reviewed changes
handler/schedule_test.go Outdated Show resolved Hide resolved
handler/schedule_test.go Outdated Show resolved Hide resolved
handler/schedule_test.go Outdated Show resolved Hide resolved
@cimnine cimnine force-pushed the TestMergeBackendWithDefaults branch from fe1dd37 to 4e4d300 Compare January 18, 2021 10:54
@cimnine
Copy link
Contributor Author

cimnine commented Jan 18, 2021

Rebased and Refactored ✅

@cimnine cimnine force-pushed the TestMergeBackendWithDefaults branch from 4e4d300 to 1fe28ce Compare January 18, 2021 11:02
ccremer
ccremer approved these changes Jan 18, 2021
View reviewed changes
handler/schedule_test.go Outdated Show resolved Hide resolved
@cimnine cimnine force-pushed the TestMergeBackendWithDefaults branch from 1fe28ce to 7862c0c Compare January 18, 2021 11:04
@cimnine cimnine merged commit 97ff1a0 into master Jan 18, 2021
@cimnine cimnine deleted the TestMergeBackendWithDefaults branch January 18, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccremer ccremer ccremer approved these changes

Assignees

@cimnine cimnine

Labels
change Generic change that is neither a fix or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cimnine @ccremer