Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up make test #342

Merged
merged 1 commit into from Feb 4, 2021
Merged

Speed up make test #342

merged 1 commit into from Feb 4, 2021

Conversation

cimnine
Copy link
Contributor

@cimnine cimnine commented Feb 2, 2021 •
edited

Summary

The target make lint depends on make vet fmt.
The target make test also depends on make vet fmt, which is redundant in that case.
To speed up running the unit tests, make vet fmt have been removed as dependencies from make test.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking,
    as they show up in the changelog
  • Update the documentation.
  • Update tests.
  • Link this PR to related issues.

@cimnine cimnine added the change Generic change that is neither a fix or feature label Feb 2, 2021
@cimnine cimnine requested a review from ccremer February 2, 2021 19:55
@ccremer
Copy link
Contributor

ccremer commented Feb 3, 2021

The vet and fmt targets are already run in the lint workflow. Is that not enough?

@cimnine
Copy link
Contributor Author

cimnine commented Feb 3, 2021

The vet and fmt targets are already run in the lint workflow. Is that not enough?

Sure. Should we remove it from make test as well then?

@ccremer
Copy link
Contributor

ccremer commented Feb 3, 2021 •
edited

Sure. Should we remove it from make test as well then?

fine by me

@cimnine
Remove vet and fmt from test step in Makefile
0be4a25 
Since these two run seperately as `make lint` anyway,
we don't need them with every test.
@cimnine
Copy link
Contributor Author

cimnine commented Feb 4, 2021

Refactored as discussed and rebased onto latest master.

@cimnine cimnine changed the title Add fmt and vet to integration-test step Speed up make test Feb 4, 2021
@cimnine cimnine merged commit 0ab8e16 into master Feb 4, 2021
@cimnine cimnine deleted the LintInIntegrationTest branch February 4, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccremer ccremer ccremer approved these changes

Assignees
No one assigned
Labels
change Generic change that is neither a fix or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cimnine @ccremer