Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce BackendInterface and document more backend settings #345

Merged
merged 2 commits into from Feb 8, 2021

Conversation

ccremer
Copy link
Contributor

@ccremer ccremer commented Feb 5, 2021

Summary

While preparing for #344 I was able to isolate improvements regarding to backends in this separate PR.
Also addresses some CodeClimate issues while at it.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking,
    as they show up in the changelog
  • Update the documentation.
  • Update tests.
  • Link this PR to related issues.

@ccremer ccremer added the change Generic change that is neither a fix or feature label Feb 5, 2021
@ccremer ccremer added this to the v1.1.0 milestone Feb 5, 2021
@ccremer ccremer requested a review from cimnine February 5, 2021 16:03
@ccremer ccremer requested review from Kidswiss and removed request for cimnine February 5, 2021 16:12
api/v1alpha1/backend.go Outdated Show resolved Hide resolved
api/v1alpha1/backend.go Show resolved Hide resolved
@ccremer
Copy link
Contributor Author

ccremer commented Feb 8, 2021

@tobru want to have a look at the documentation?

@ccremer ccremer changed the title Introduce BackendInterface to replace if-else mess Introduce BackendInterface and document more backend settings Feb 8, 2021
Copy link
Contributor

@tobru tobru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation LGTM

@ccremer ccremer merged commit ec068a6 into master Feb 8, 2021
@ccremer ccremer deleted the backend-restructure branch February 8, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change Generic change that is neither a fix or feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants