Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate keys initialDelaySeconds, timeoutSeconds #452

Merged
merged 2 commits into from
Jul 7, 2021

Conversation

psy-q
Copy link
Contributor

@psy-q psy-q commented Jul 5, 2021

Summary

This PR removes two duplicate keys from the MariaDB tutorial deployment's spec.template.spec.readinessProbe section. This way, the k8up tutorial works again as documented.

Otherwise kubectl throws an error:

error: map[string]interface {}(nil): yaml: unmarshal errors:
  line 37: mapping key "timeoutSeconds" already defined at line 27
  line 36: mapping key "initialDelaySeconds" already defined at line 28

At least when using kubectl 1.21.1 against apiserver 1.20.2. I'm not sure which part (kubectl or the API server) does these validations.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking,
    as they show up in the changelog

On newer versions of kubectl (e.g. 1.21.1) the manifests
won't apply otherwise.
@psy-q psy-q added the bug Something isn't working label Jul 5, 2021
@tobru tobru merged commit eab2ae5 into master Jul 7, 2021
@tobru tobru deleted the fix_duplicate_key branch July 7, 2021 11:49
@ccremer ccremer added documentation This issue or pull request affects documentation and removed bug Something isn't working labels Jul 8, 2021
@ccremer
Copy link
Contributor

ccremer commented Jul 8, 2021

(Please label documentation fixes with documentation :) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This issue or pull request affects documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants