Validate and update tutorial #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccremer
reviewed
Jul 8, 2021
Co-authored-by: Chris <github.account@chrigel.net>
Co-authored-by: Chris <github.account@chrigel.net>
ccremer
reviewed
Jul 12, 2021
ccremer
reviewed
Jul 12, 2021
Co-authored-by: Chris <github.account@chrigel.net>
Co-authored-by: Chris <github.account@chrigel.net>
Co-authored-by: Chris <github.account@chrigel.net>
Kidswiss
reviewed
Jul 12, 2021
|
I only had one remark so far. It's not really important, but if you have time/wish to experiment around feel free to try it out. |
ccremer
reviewed
Jul 12, 2021
ccremer
approved these changes
Jul 13, 2021
|
LGTM Maybe in the future we could migrate it away from minikube? Kind would be perfectly fine here. |
Kidswiss
approved these changes
Jul 13, 2021
|
I spotted a wrong path from when I moved the backup example YAML but I think now I'm really really done with this :) |
feel free to merge then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The tutorial had some parts that didn't match reality anymore. There were also some defects (missing files, wrong paths) from when the separate tutorial repo was merged in with this main repo. I tried running every step of the tutorial and fixed as I went along.
There is a pretty signifcant change to the way WordPress is restored: I couldn't get it to work as previously documented, nothing would be restored to the existing and bound PVC. A solution that worked was to bind another empty PVC to
/restoreand restore to this, then rsync the files using a shell in the container. The scripts have been adapted for this.Checklist
bug,enhancement,documentation,change,breaking,as they show up in the changelog