Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the official mariadb image in tutorial #460

Merged
merged 3 commits into from
Jul 23, 2021
Merged

Use the official mariadb image in tutorial #460

merged 3 commits into from
Jul 23, 2021

Conversation

bastjan
Copy link
Contributor

@bastjan bastjan commented Jul 16, 2021

Summary

  • Uses the official, non-deprectaed mariadb image.
  • Fixes quoting in restore job.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking,
    as they show up in the changelog
  • Update the documentation.

@bastjan
Use official, non-deprected mariadb image
194f5a7
@bastjan
Revert "Fix quoting"
2013da9 
The enviroment should come from the pod, not from the shell.

This reverts commit 223533e.
@bastjan bastjan added the documentation This issue or pull request affects documentation label Jul 16, 2021
@bastjan bastjan requested a review from psy-q July 16, 2021 11:02
@bastjan bastjan requested a review from ccremer July 16, 2021 11:12
@bastjan bastjan merged commit 7b47bcd into master Jul 23, 2021
@bastjan bastjan deleted the improve-tutorial branch July 23, 2021 06:32
@ccremer ccremer changed the title Validate tutorial Use the official mariadb image in tutorial Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccremer ccremer ccremer approved these changes

@psy-q psy-q Awaiting requested review from psy-q

Assignees
No one assigned
Labels
documentation This issue or pull request affects documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bastjan @ccremer