Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage kind version via go.mod #468

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Manage kind version via go.mod #468

merged 1 commit into from
Jul 30, 2021

Conversation

cimnine
Copy link
Contributor

@cimnine cimnine commented Jul 30, 2021 •
edited

Summary

Until now, the version of kind was managed via a variable in Makefile.vars.mk. This PR adds kind to the tools.go file and thereby the version is henceforth controlled via the go.mod file. This allows renovate to automatically update kind in the future. Kind will have to be started by go run sigs.k8s.io/kind instead of ./testbin/kind, yet manual invocation should not be necessary anyway.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking,
    as they show up in the changelog
  • Update the documentation.
  • Update tests.
  • Link this PR to related issues.

@cimnine cimnine added the change Generic change that is neither a fix or feature label Jul 30, 2021
@cimnine cimnine self-assigned this Jul 30, 2021
@cimnine cimnine marked this pull request as ready for review July 30, 2021 08:00
@cimnine cimnine requested a review from ccremer July 30, 2021 08:00
ccremer
ccremer approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@ccremer ccremer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uuh, nice!

@cimnine cimnine merged commit e3845ad into master Jul 30, 2021
@cimnine cimnine deleted the KindGoMod branch July 30, 2021 08:38
@ccremer ccremer mentioned this pull request Aug 2, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccremer ccremer ccremer approved these changes

Assignees

@cimnine cimnine

Labels
change Generic change that is neither a fix or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cimnine @ccremer