Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Architecture Documentation #498

Merged
merged 2 commits into from
Sep 14, 2021
Merged

Improve Architecture Documentation #498

merged 2 commits into from
Sep 14, 2021

Conversation

cimnine
Copy link
Contributor

@cimnine cimnine commented Sep 10, 2021

Summary

Improves the documentation about the inner workings of K8up.

It already contains changes that will be merged in #497.

Closes #482.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking,
    as they show up in the changelog
  • Update the documentation.
  • Update tests.
  • Link this PR to related issues.

@cimnine cimnine added the documentation This issue or pull request affects documentation label Sep 10, 2021
@cimnine cimnine self-assigned this Sep 10, 2021
@cimnine cimnine marked this pull request as ready for review September 10, 2021 15:21
@cimnine cimnine added this to the Wrestic Integration milestone Sep 10, 2021
tobru
tobru approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@tobru tobru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the write-up, looks good. Just one small hint about "wrestic", after that it can be merged.

docs/modules/ROOT/pages/references/restic-config-reference.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/explanations/architecture.adoc Show resolved Hide resolved
@cimnine cimnine merged commit daad57c into master Sep 14, 2021
@cimnine cimnine deleted the architecture branch September 14, 2021 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobru tobru tobru approved these changes

@ccremer ccremer ccremer approved these changes

Assignees

@cimnine cimnine

Labels
documentation This issue or pull request affects documentation
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

Document the architecture of k8up
3 participants
@cimnine @tobru @ccremer