Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic when merging PodSecuritySontext from Schedule #676

Merged
merged 1 commit into from
May 25, 2022
Merged

Fix panic when merging PodSecuritySontext from Schedule #676

merged 1 commit into from
May 25, 2022

Conversation

zugao
Copy link
Collaborator

@zugao zugao commented May 24, 2022

Summary

Closes #638

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking,
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@zugao zugao added the bug Something isn't working label May 24, 2022
@zugao zugao requested a review from a team as a code owner May 24, 2022 09:07
@zugao zugao requested review from bastjan and Kidswiss and removed request for a team May 24, 2022 09:07
@zugao zugao marked this pull request as draft May 24, 2022 09:08
@zugao zugao force-pushed the bug/resolve-psc-merge-error#638 branch from 8e73198 to 49656be Compare May 24, 2022 09:13
@zugao zugao requested a review from ccremer May 24, 2022 09:16
@zugao zugao marked this pull request as ready for review May 24, 2022 09:20
ccremer
ccremer suggested changes May 24, 2022
View reviewed changes
operator/handler/schedule_test.go Outdated Show resolved Hide resolved
operator/handler/schedule_test.go Outdated Show resolved Hide resolved
operator/handler/schedule_test.go Outdated Show resolved Hide resolved
operator/handler/schedule_test.go Outdated Show resolved Hide resolved
operator/handler/schedule_test.go Outdated Show resolved Hide resolved
@ccremer ccremer removed the request for review from bastjan May 24, 2022 09:26
@zugao zugao force-pushed the bug/resolve-psc-merge-error#638 branch 3 times, most recently from 5eebc98 to 2254cdc Compare May 24, 2022 17:00
@zugao zugao requested a review from ccremer May 24, 2022 17:00
@zugao zugao force-pushed the bug/resolve-psc-merge-error#638 branch 2 times, most recently from b087636 to fb5e94d Compare May 25, 2022 08:31
@ccremer ccremer changed the title Fix pod security context merge #638 Fix panic when merging PodSecuritySontext from Schedule May 25, 2022
ccremer
ccremer approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@ccremer ccremer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one slight name suggestion, otherwise LGTM

operator/handler/schedule_test.go Outdated Show resolved Hide resolved
@zugao
Fix pod security context merge
e8b435a 
Signed-off-by: Gabriel Saratura <gabriel.saratura@vshn.ch>
@zugao zugao force-pushed the bug/resolve-psc-merge-error#638 branch from 0bebf12 to e8b435a Compare May 25, 2022 08:35
Kidswiss
Kidswiss approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zugao zugao changed the title Fix panic when merging PodSecuritySontext from Schedule Fix panic when merging PodSecuritySontext from Schedule #638 May 25, 2022
@zugao zugao merged commit ad1d79b into master May 25, 2022
@zugao zugao deleted the bug/resolve-psc-merge-error#638 branch May 25, 2022 09:25
@ccremer ccremer changed the title Fix panic when merging PodSecuritySontext from Schedule #638 Fix panic when merging PodSecuritySontext from Schedule May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kidswiss Kidswiss Kidswiss approved these changes

@ccremer ccremer ccremer approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

K8up operator crashes in panic because of missing API implementation
3 participants
@zugao @Kidswiss @ccremer