Add '--host' parameter to 'restic forget' call in Prune jobs #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'backup' subcommand is using the --host parameter, but not when pruning. This should make it more consistent. Signed-off-by: ccremer <github.account@chrigel.net>
ccremer
requested review from
bastjan and
Kidswiss
and removed request for
a team and
bastjan
|
@Kidswiss Are you aware of any locations where documentation needs to be updated? |
|
Also, I didn't do an in-depth test, I just ran |
ccremer
changed the title
Kidswiss
approved these changes
Jun 29, 2022
There was a problem hiding this comment.
LGTM
The docs only talk about backend here: https://k8up.io/k8up/2.3/references/object-specifications.html#_retention
It doesn't specify anything about on what namespaces it gets applied to. Maybe we could add a note that it is applied by namespace.
Signed-off-by: ccremer <github.account@chrigel.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
restic backupsubcommand is using the--hostparameter, but not when pruning.This PR adds
--hostto therestic forgetsubcommand to make it more consistent.See also https://restic.readthedocs.io/en/v0.13.1/060_forget.html#removing-snapshots-according-to-a-policy
Fixes #686
Checklist
bug,enhancement,documentation,change,breaking,as they show up in the changelog