Skip to content
This repository has been archived by the owner on Jan 17, 2022. It is now read-only.

Signals don't work when XdebugHandler restarts process #13

Closed
k911 opened this issue Oct 14, 2018 · 0 comments
Closed

Signals don't work when XdebugHandler restarts process #13

k911 opened this issue Oct 14, 2018 · 0 comments
Labels
kind/bug/possible Something probably isn't working

Comments

@k911
Copy link
Owner

k911 commented Oct 14, 2018

XdebugHandler restarts cli process and don't pass the signals to the child process.

Example:

  1. Run server with swoole:server:run command
  2. Click CONTROL-C
  3. Scripts exits immediately without "Swoole HTTP Server has been successfully shutdown.".

It might be needed to use another approach for disabling Xdebug. (Symfony/Process?)
@k911 k911 added the kind/bug/possible Something probably isn't working label Oct 14, 2018
@k911 k911 changed the title Signals doesn't work when XdebugHandler restarts process Signals don't work when XdebugHandler restarts process Oct 14, 2018
@k911 k911 mentioned this issue Oct 21, 2018
Merged
k911 added a commit that referenced this issue Oct 21, 2018
@k911
fix(xdebug-handler): Replace with custom solution
0f89f0a 
Composer\XdebugHandler does not support TTY detection and signals forwarding.
To overcome this issue use Symfony\Process to execute restarted process.

Closes #13
k911 added a commit that referenced this issue Oct 24, 2018
@k911
fix(xdebug-handler): Replace with custom solution
fe060eb 
Composer\XdebugHandler does not support TTY detection and signals forwarding.
To overcome this issue use Symfony\Process to execute restarted process.

Closes #13
k911 added a commit that referenced this issue Oct 24, 2018
@k911
fix(xdebug-handler): Replace with custom solution
175d8fa 
Composer\XdebugHandler does not support TTY detection and signals forwarding.
To overcome this issue use Symfony\Process to execute restarted process.

Closes #13
@k911 k911 closed this as completed in #18 Oct 24, 2018
k911 added a commit that referenced this issue Oct 24, 2018
@k911
fix(xdebug-handler): Replace with custom solution
0dc13f0 
Composer\XdebugHandler does not support TTY detection and signals forwarding.
To overcome this issue use Symfony\Process to execute restarted process.

Closes #13
k911 pushed a commit that referenced this issue Oct 24, 2018
chore(release): v0.4.1 🎉
836f640 
##  (2018-10-24)

* fix(boot-manager): Don't boot not bootable objects ([8ad97a2](8ad97a2)), closes [#19](#19)
* fix(xdebug-handler): Replace with custom solution ([0dc13f0](0dc13f0)), closes [#13](#13)
* chore(deps): Upgrade dependencies ([afc0bfc](afc0bfc))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/bug/possible Something probably isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@k911