Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't retry failing uploads indefinitely #3986

Open
muessjoeh opened this issue Mar 26, 2019 · 15 comments
Open

Don't retry failing uploads indefinitely #3986

muessjoeh opened this issue Mar 26, 2019 · 15 comments
Labels
type: bug Something is causing incorrect behavior or errors

Comments

@muessjoeh
Copy link

Every 3 months or so I have a problem accessing my web.de account: When I activate the directory list (in German 'Ordnerliste'), I see that ever folder has an error message (the beginning is 'SSLException: Write error:'; how can I see the rest?). From now on, fetching the mails is approximately 10x slower, and storing changed mails (e.g. with a changed read status) is not working at all. The only solution that I know of is a fresh install, what of course repeats every 3 months.

@cketti

This comment has been minimized.

@cketti cketti added type: bug Something is causing incorrect behavior or errors status: needs information Needs more information to proceed labels Mar 26, 2019
@muessjoeh

This comment has been minimized.

@cketti

This comment has been minimized.

@cketti cketti closed this as completed Apr 5, 2019
@chrisgee
Copy link

I may be having the same issue as described here. Sent messages are not stored on the server (although they are shown in the local sent folder). Read status is not updated, etc.

Therefore I attach a log here.
k9-log.txt

Environment

K-9 Mail version:
version used is com.fsck.k9 version 5.600 as installed by f-droid.

Android version:
7.1.2

Account type (IMAP, POP3, WebDAV/Exchange):
IMAP account

Please let me know if more information is needed

@muessjoeh

This comment has been minimized.

@tim-kiefer

This comment has been minimized.

@cketti
Copy link
Member

cketti commented Jun 29, 2019

@chrisgee: Thanks for the log. The message being uploaded is quite large. Chances are the server is closing the connection because it considers the message too large. Or maybe the quota is exceeded.
Unfortunately, K-9 Mail considers this to be a temporary error and will try to upload the message over and over again. All other command wait in the queue until the upload command succeeds (or fails permanently; which, in this case, it never does). That explains why the read status is never updated.

@chrisgee
Copy link

chrisgee commented Jun 30, 2019 via email

@muessjoeh

This comment has been minimized.

@chrisgee

This comment has been minimized.

@muessjoeh

This comment has been minimized.

@cketti cketti reopened this Oct 12, 2019
@cketti cketti removed the status: needs information Needs more information to proceed label Oct 12, 2019
@cketti
Copy link
Member

cketti commented Oct 12, 2019

It's unclear how this situation should be handled best. A connection could be closed at any time without it being a permanent error.
We could count the number of upload attempts and stop trying automatically after a certain amount of attempts. We already do this for send failures.

@muessjoeh
Copy link
Author

How is this handled now?
Are there any hints WHY this is happening every now and then?

@cketti cketti changed the title Regular SSLException: Write error Don't retry failing uploads indefinitely Oct 13, 2019
@chrisgee
Copy link

I am quite ignorant with respect to what is going on in K9 internally.
But I imagine the following:

If there is a list of commands to the server to be processed, wouldn't
it make sense to just go through the list one by one (if there is no
specific order required) and keep failed commands in queue until the
next attempt.
Also it would be very helpful if repeated failures would be reported to
the user so that he may take a custom action on those?
Like this commands without repeated failure could be processed and would
not be blocked in the mean time...?

Just an idea...

@muessjoeh
Copy link
Author

... but it sounds like a good one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something is causing incorrect behavior or errors
Projects
None yet
Development

No branches or pull requests

4 participants