Use Timber for Logging #2309
Merged
Use Timber for Logging #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cketti
requested changes
Mar 2, 2017
| import timber.log.Timber; | ||
| import timber.log.Timber.DebugTree; | ||
|
|
||
| import static timber.log.Timber.i; |
There was a problem hiding this comment.
Weird, android studio did this in some files but not others. *shrug
| @@ -760,7 +760,7 @@ private void resetVisibleLimits() { | |||
| try { | |||
| getLocalStore().resetVisibleLimits(getDisplayCount()); | |||
| } catch (MessagingException e) { | |||
| Log.e(K9.LOG_TAG, "Unable to reset visible limits", e); | |||
| Timber.e("Unable to reset visible limits", e); | |||
There was a problem hiding this comment.
With Timber exceptions are the first argument. Format string arguments go at the end.
| @@ -953,8 +953,8 @@ public void setLocalStorageProviderId(String id) { | |||
| switchLocalStorage(id); | |||
| successful = true; | |||
| } catch (MessagingException e) { | |||
| Log.e(K9.LOG_TAG, "Switching local storage provider from " + | |||
| mLocalStorageProviderId + " to " + id + " failed.", e); | |||
| Timber.e("Switching local storage provider from " + | |||
There was a problem hiding this comment.
We should probably switch away from doing string concatenations in log messages. Timber supports format strings. So this could be:
Timber.e(e, "Switching local storage provider from %s to %s failed", mLocalStorageProviderId, id);There was a problem hiding this comment.
Sure. No need to do it all at once though.
|
We still need to update Timber when the debug logging setting is changed by the user. |
|
logging now enabled if K9.DEBUG || BuildConfig.DEBUG |
cketti
approved these changes
Mar 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it says on the tin :) as discussed in #1732.
Includes only the main source, notably not k9mail-library.