Add abstraction layer for local message storage in ImapSync #3421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valodim
reviewed
Jun 2, 2018
|
|
||
| unsyncedMessages.add(message); | ||
| } else { | ||
| Timber.v("Message with uid %s is partially or fully downloaded", message.getUid()); |
There was a problem hiding this comment.
where'd this part go? not needed anymore because of the stuff below?
There was a problem hiding this comment.
ImapStore never returns messages with either Flag.X_DOWNLOADED_FULL or Flag.X_DOWNLOADED_PARTIAL set. I removed the branch so I didn't have to add additional methods to BackendFolder.
|
only did a cursory sanity check, looks ok to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.