Material paper drawer background #3851
Conversation
|
By the way, the image is not repeatable. It looks too symmetric if it's repeatable, in my opinion. |
|
@ByteHamster: Can you please create the PNGs for the different density buckets we support for regular drawables (mdpi tp xxhdpi). |
|
I think it would look good to have the sidebar menu go below the status bar like in most Google apps. What do you think about that? |
👍 |
|
No most google apps don't do this. It was a thing when the first version of Material design was released. |
|
Hi @Dafnik, not sure if we are talking about the same thing. The Google apps I use (Calendar, Gmail, Play store, Play console, Translate) all display the sidebar below the status bar. Only Google Maps does not display the sidebar below the status bar.
|
|
Oh I'm sorry, I thought you talked about the toolbar. My fault 👍 |
ByteHamster
force-pushed
the
drawer-bg
branch
from
87b8bb4
to
e8da523
Compare
| generate hdpi 576 324 | ||
| generate xhdpi 768 432 | ||
| generate xxhdpi 1152 648 | ||
| #generate xxxhdpi 1728 972 |
There was a problem hiding this comment.
Why is this commented out? Not used?
There was a problem hiding this comment.
cketty told me to support mdpi tp xxhdpi. Just in case we want to support xxxhdpi sometimes, there sizes are already here.
There was a problem hiding this comment.
Err, sounds legit. And it's not commented-out because the file generated would be big or for what reason?
There was a problem hiding this comment.
Yes, I did not want to add more big png files. I don't know what cketty thinks about that
There was a problem hiding this comment.
Got it, for me it's OK just wanted to clarify, thanks 👍
There was a problem hiding this comment.
xxxhdpi is ridiculously dense and really should only be used for launcher icons because "some app launchers display your app icon as much as 25% larger than what's called for by the device's density bucket". (https://developer.android.com/training/multiscreen/screendensities)
See also https://developer.android.com/guide/topics/resources/providing-resources
|
👍 |
The background even works well with yellow. The account chip still looks strange when selecting yellow: restricting the account colors to not allow yellow will be done in another PR.