PGP/Mime support in K-9 #4

mpasch · 2011-03-08T13:16:27Z

Hey guys,

I'm working on PGP/Mime support in K-9 based on APG for the tarent company.

Since we'd like to see the code upstream, I wanted to ask for your opinion about this "patch".
You probably don't want to accept this request at this point, because of bugs 1) and 2) (see below).
I still would like to know what you think, cause I won't have much time to spend on this later.

I use the current version of APG in the android market. I'm working with an HTC Desire Z. (non-root android 2.2.1)

What's working (both send and receive)

encrypted mails, encrypted+signed mails (attachments are encrypted, too)

What's not working:

send/receive signed-only mails (you can still read them, but the signature is not checked)

Known Bugs:

there is no warning that sending signed-only mails does not work (APG fails)
because the whole email including attachments is sent to APG as an byte array, sending attachments >~500Kb fails (without error message). This needs to be replaced with passing it over using an Uri (content://), I would like to use the K-9 content-provider here, do you think that might work? (Is it saving the data as tempfile?, is that a security issue?)
receiving attachments works with common attachment sizes you would except on a smartphone (so a 3-5MB file is no problem, my 16MB-testfile caused an endless loop)
the PGP/Mime specification requires the following header:

Content-Type: multipart/encrypted; boundary="...."; protocol="application/pgp-encrypted"

due to the way K-9 stores messages in the local store the protocol value gets lost (I think this is a known problem in k-9)
Thunderbird, K-9, and Kontact do not care about the missing attribute, I haven't tested any other clients, so I hope this won't be a problem. (I think fixing this would require massive changes in K-9)

I think 5) and 6) are not related to my patch, if they are please let me know.

if you're sending an attachment using OIFileManager, the full path is used as filename
PGP/Inline sending does not work if you have HTML enabled, I think this is tracked in Issue 3051

Thank you very much for your thoughts!

I hope we can get PGP/Mime to work in K-9!!

Mattis Pasch

(both with attachments) receiving: PGP/Mime encrypted, encrypted+signed (both with attachments) not working: PGP/Mime signed only messages (both send and receive)

-toast-message that attachments are not supported ignored if PGP/Mime-Checkbox is activated -added toast-message for big encrypted messages (download first) -moved pgp/mime-encryption check to Apg.java

mpasch · 2011-03-08T13:29:51Z

src/com/fsck/k9/mail/internet/MimeHeader.java

-    private String mCharset = null;
+
+    // use UTF-8 as standard to prevent NullPointerExceptions
+    private String mCharset = "UTF-8";


There were problems with NullPointerException and with german Umlauts in message titles (I know they're not allowed in the specifiation but they caused my K-9-Inbox to not work at all)

I don't know if this is related to PGP/Mime

obra · 2011-03-08T18:14:55Z

Hi! I thing you're right that this isn't quite ready for merge yet. The best thing to do is to resend the text of your pull-request to the mailing list (signup at http://code.google.com/p/k9mail/ ) and we can chat about the right way forward from there. I'm going to be really happy to get this landed in K-9. All my GPG-using correspondents use pgp/mime :)

Unfortunately is requires a patched version of APG :( Fixes: - Sending of PGP/Mime encrpyted mails with sizes over 50Kb works (7,5MB tested succesfully on HTC Desire Z) -> this requried a new provider (SimpleFileProvider) and secure tempfile deletion which is done in Apg.java (there are a few bugs in APG which make this fail without patch) - Deletion of temporary files in APG (unencrypted Data) (requires APG-Patch, without the patch it just doesn't do it, everything still works) - added Toast if someone trys to send a PGP/Mime signed-only mail - removed PGP/Mime verify button and added toast (cause verifying does not work) Known Bugs: -there are no notification handling big encrypted mails (sizes over the tested 7,5MB) -PGP/Mime encrypted messages sent by K9 miss the protocol attribute in Content-Type header (which doesn't prevent any tested mail clients from reading/decrypting it correctly) - PGP/Mime signed-only mails do not work (send/receive) but there is a message warning the user)

according to RFC 1521

mpasch · 2011-03-10T09:54:28Z

Sorry, I'm working with GitHub for the first time and I didn't realize the new commit would be added here...
The new commit will actually make things even more complicated, but resolves most of the problems.
It actually requires a small patch in APG
See APG-Issue on Google-Code:
http://code.google.com/p/android-privacy-guard/issues/detail?id=99

edit
The other APG-Patch is not required but fixes a problem with saving temporary files(they are never deleted)
http://code.google.com/p/android-privacy-guard/issues/detail?id=98

mpasch · 2011-03-10T10:41:10Z

If you want to test the project:

https://evolvis.org/frs/?group_id=115

edit: english translation of release notes added

Forse-Close - delete encrypted file in APG (if APG supports it...) - improved temp-file-deletion method (faster and more reliable)

phoerious · 2012-03-05T10:07:28Z

Sorry for digging this up, but what is the status of this? Having support for PGP/MIME in K-9 Mail would be very helpful. With the current version I'm not able to read PGP/MIME encrypted messages at all. It just says "no text" and shows the encrypted message as attachment (.asc) whose contents I have to copy to APG manually.

wridgers · 2012-05-09T12:58:37Z

What is the status of this now?

sesceu · 2012-07-19T10:50:11Z

I'd be interested in the status as well? PGP/MIME would be really great!

bbock · 2012-07-29T19:49:10Z

+1

kiplingw · 2012-11-09T06:42:20Z

Thanks mpasch for the work you are doing.

charlieamadeus · 2012-12-12T00:38:47Z

Thank your for getting this project started, any updates?

cyberpunkedu · 2012-12-26T18:13:35Z

This is so great. Can't wait for PGP/MIME support. Thanks!

cketti · 2013-03-10T05:57:44Z

To be able to properly support PGP/MIME (and S/MIME) K-9 Mail has to change the way messages are stored in the local database. Currently information necessary to verify the integrity of a message is discarded. Until we change that every attempt at supporting PGP/MIME is a hack at best.

h-2 · 2014-01-21T14:07:43Z

any news on this? PGP/Mime is, like, reeeally important!

Thanks!

jhgg · 2014-02-05T21:44:11Z

+1 on this too.

webratte · 2014-05-04T16:32:17Z

There are News about PGP/MIME support?
I think i'ts a very important feature.

cketti · 2014-05-11T19:48:31Z

https://groups.google.com/forum/#!topic/k-9-dev/ibSwkJVYTU0

Diapolo · 2015-05-19T19:41:28Z

What can be done to get this forward? We really need PGP/SMIME support for K9 to become perfectly usable!

dschuermann · 2015-05-19T22:13:21Z

@Diapolo work on https://github.com/k9mail/k-9/milestones/PGP/MIME

mpasch added 4 commits March 7, 2011 15:16

/res/ changes for PGP-Mime

3f7b1a4

/res/ changes for PGP-Mime

bfe271e

working: sending: PGP/Mime encrypted, encrypted+signed

30cb960

(both with attachments) receiving: PGP/Mime encrypted, encrypted+signed (both with attachments) not working: PGP/Mime signed only messages (both send and receive)

fixed:

f36b7dd

-toast-message that attachments are not supported ignored if PGP/Mime-Checkbox is activated -added toast-message for big encrypted messages (download first) -moved pgp/mime-encryption check to Apg.java

mpasch reviewed Mar 8, 2011
View reviewed changes

mpasch added 2 commits March 10, 2011 10:33

Added comment to MimeMultipart which explains CRLF in boundaries

49941e7

according to RFC 1521

mpasch added 2 commits March 11, 2011 11:48

- added Toast if message is too large to encrypt instead of

e3edb72

Forse-Close - delete encrypted file in APG (if APG supports it...) - improved temp-file-deletion method (faster and more reliable)

Added nice lock-icon next to PGP/Mime encrypted mails

d8690e6

obra mentioned this pull request Mar 23, 2012

Settings autocomplete #127

Closed

dschuermann mentioned this pull request Nov 2, 2012

PGP/MIME in K9-Mail open-keychain/open-keychain#13

Closed

cketti closed this Mar 10, 2013

grugq mentioned this pull request Jun 26, 2013

added support for PGP/MIME encrypted emails. #322

Closed

dschuermann mentioned this pull request Sep 17, 2013

PGP/MIME API open-keychain/open-keychain#130

Closed

cketti mentioned this pull request Feb 12, 2014

Functionality to enable k-9 to decrypt and display RFC 2440 and RFC 3156 #408

Closed

deviantollam mentioned this pull request Jan 20, 2017

GPG/PGP signing key should be on identity not account #942

Open

Hilmic mentioned this pull request Mar 26, 2017

Next-/previous-buttons in E-Mail view no longer work properly (since Update 5.206) #2446

Closed

philipwhiuk mentioned this pull request Jan 26, 2018

Please revert to old, pre v5.400, app icon! #2998

Closed

AlainKnaff mentioned this pull request Mar 30, 2019

Cannot copy-paste from k9-mail to Jackpal terminal application #3994

Closed

h2dden mentioned this pull request Jan 7, 2020

cannot connect to SMTP google from behind vpn #4426

Closed

cparisot89 mentioned this pull request Apr 10, 2020

Deleted messages from inbox not deleted on webmai #4653

Closed

erwin68 mentioned this pull request Aug 12, 2021

syncing of read status doesn't work anymore #5558

Closed

This was referenced Oct 19, 2023

Cannot set up outlook office365 mail #7141

Closed

Unable to access email on Office365 #7270

Closed

NilsHoyer mentioned this pull request Jun 13, 2024

Sending mail from the output folder fails, sometimes #7915

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PGP/Mime support in K-9 #4

PGP/Mime support in K-9 #4

mpasch commented Mar 8, 2011

mpasch Mar 8, 2011

obra commented Mar 8, 2011

mpasch commented Mar 10, 2011

mpasch commented Mar 10, 2011

phoerious commented Mar 5, 2012

wridgers commented May 9, 2012

sesceu commented Jul 19, 2012

bbock commented Jul 29, 2012

kiplingw commented Nov 9, 2012

charlieamadeus commented Dec 12, 2012

cyberpunkedu commented Dec 26, 2012

cketti commented Mar 10, 2013

h-2 commented Jan 21, 2014

jhgg commented Feb 5, 2014

webratte commented May 4, 2014

cketti commented May 11, 2014

Diapolo commented May 19, 2015

dschuermann commented May 19, 2015

PGP/Mime support in K-9 #4

PGP/Mime support in K-9 #4

Conversation

mpasch commented Mar 8, 2011

mpasch Mar 8, 2011

Choose a reason for hiding this comment

obra commented Mar 8, 2011

mpasch commented Mar 10, 2011

mpasch commented Mar 10, 2011

phoerious commented Mar 5, 2012

wridgers commented May 9, 2012

sesceu commented Jul 19, 2012

bbock commented Jul 29, 2012

kiplingw commented Nov 9, 2012

charlieamadeus commented Dec 12, 2012

cyberpunkedu commented Dec 26, 2012

cketti commented Mar 10, 2013

h-2 commented Jan 21, 2014

jhgg commented Feb 5, 2014

webratte commented May 4, 2014

cketti commented May 11, 2014

Diapolo commented May 19, 2015

dschuermann commented May 19, 2015