make k9mail build in aosp tree

[ghost]

this enables me building k9 directly in my custom rom aosp tree.. few string localizations and a few empty methods.

[obra]

As a note, we can't even consider a pull request that changes K-9's icon to the android stock icon

[ghost]

I didn't intent pull-requesting this commit, only the two others. Sorry, I'm new to github :)

removing the line would maybe be also an option, aosp complained that "" needs to be localized.

[cketti]

K-9 Mail doesn't build outside the AOSP tree with the "missing methods" patch. Any idea on how to make this work?

[ghost]

Thank you for looking into this and trying to merge the request :)

I'm afraid I never build k9 outside the AOSP with the patches enabled. Didn't think that there would be any problems, since it's basically some methods that just return false when called...
I just added a return false function for everything the compiler was complaining about.

What are the error messages?

[cketti]

It's mostly the Override annotations (which are not that much of a problem). But "mCursor.abortUpdates();" in MonitoredCursor.abortUpdates() fails to compile because CrossProcessCursor.abortUpdates() is undefined in the SDK.

[ghost]

I only implemented those methods because aosp complained not having them, they are not supposed to alter k9mail in any way. I took mCursor.abortUpdates() because in the original methods of k9 i found similar implementations of other methods (just forwarding them to mCursor.name() ), so i did the same.

Does it complain if you just return instead of doing anything? That may be an option.
If this solves the problem, I can verify if it still builds in aosp, if you don't have an aosp tree to test it with.

[ghost]

have a look at the last 3 commits in the 3.8-MAINT branch:
https://github.com/kechagia/k-9/commits/3.8-MAINT

it compiles (and works) now in AOSP tree, as well as using "ant debug".

I didn't open a new pull request, because I dunno how to only select the last 3 commits, whithout the stock icon patch :)

[obra]

On Thu, May 05, 2011 at 06:39:30AM -0700, kechagia wrote:

have a look at the last 3 commits in the 3.8-MAINT branch:
https://github.com/kechagia/k-9/commits/3.8-MAINT

it compiles (and works) now in AOSP tree, as well as using "ant debug".

I didn't open a new pull request, because I dunno how to only select the last 3 commits, whithout the stock icon patch :)

You need to create a new branch for your pull request. Also, please don't supply commits on maintenance branches, instead branch from master.

Thanks!

[ghost]

ok thank you. I updated this pull request, using the master branch. i only tested the patch with android-10 sdk, aosp 2.3.4 and 3.8-MAINT, though.