Changed default color for registered contacts to a better readability #5865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or (the first color from the color chooser)
cketti
reviewed
Jan 15, 2022
There was a problem hiding this comment.
Nice 👍 I like that you wrote migrations.
I'm not sure about the new color. Since we're changing the color from under the users (when they use the default value), it's probably better to pick a color that is not too different from the previous one, i.e. a blue tone.
I have no strong opinion on that, though. If you think the new color is a better fit, I'm fine with keeping it.
app/core/src/main/java/com/fsck/k9/preferences/GeneralSettingsDescriptions.java
Outdated
Show resolved
Hide resolved
app/storage/src/main/java/com/fsck/k9/preferences/migrations/StorageMigrationTo16.kt
Outdated
Show resolved
Hide resolved
- Remove duplicate comments - Fix migration method name - Change color to a blue tone with similar contrast
|
I resolved the points and chose a blue from the default colors that has a similiar contrast. |
|
Thanks 👍 |
johnjohndoe
pushed a commit
to johnjohndoe/k-9
that referenced
this pull request
Mar 30, 2023
Change default value of `registeredNameColor` to have enough contrast in both the light and dark theme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0xFF00008Fto0xFF1093F5(#1093F5) for better readability on dark theme.#1093F5is one of the colors from the preferance color pickerfix #5755