Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Strict" flag to override error in production environment #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dkalamar
Copy link

Fixes #10

I have a similar use-case to the issue mentioned in #10 and in an effort to reduce additional dependences, such as env-cmd, opted to alter this code to provide a "non-strict" option to production builds.
I've added a boolean flag "--strict" or "-s" to allow production builds to use the default values provided in the .env file.

I believe this adds two key uses:

  • The option to default to existing values in cases where that variable may not always be provided
  • The ability to specify environmental variable overrides of the .env for local runs, and observe the effect in a development build.

I also added in a test for a line in production builds that was previously uncovered.

@seanblonien
Copy link
Contributor

@dkalamar could you also add brief documentation describing the flag to the README's "CLI options" section?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It causes an issue during the build time of production.
2 participants