KAA-1279: Fixed about 250 warnings

server/node/src/main/java/org/kaaproject/kaa/server/admin/client/layout/CustomDeckLayoutPanel.java

@@ -327,11 +327,11 @@ private void doBeforeLayout() {
     double horizDirection = isAnimationVertical ? 0.0
         : LocaleInfo.getCurrentLocale().isRTL() ? -direction : direction;
 
-      /*
-       * Position the old widget in the center of the panel, and the new widget
-       * off to one side. If the old widget is the same as the new widget, then
-       * skip this step.
-       */
+    /*
+     * Position the old widget in the center of the panel, and the new widget
+     * off to one side. If the old widget is the same as the new widget, then
+     * skip this step.
+     */
     hidingWidget = null;
     if (visibleWidget != lastVisibleWidget) {
       // Position the layers in their start positions.
@@ -362,12 +362,12 @@ private void doBeforeLayout() {
       // The new layer ends centered in the panel.
       newLayer.setTopHeight(0.0, Unit.PCT, 100.0, Unit.PCT);
       newLayer.setLeftWidth(0.0, Unit.PCT, 100.0, Unit.PCT);
-        /*
-         * The call to layout() above could have canceled an existing layout
-         * animation, which could cause this widget to be hidden if the user
-         * toggles between two visible widgets. We set it visible again to ensure
-         * that it ends up visible.
-         */
+      /*
+       * The call to layout() above could have canceled an existing layout
+       * animation, which could cause this widget to be hidden if the user
+       * toggles between two visible widgets. We set it visible again to ensure
+       * that it ends up visible.
+       */
       setWidgetVisible(visibleWidget, newLayer, true);
     }
 
@@ -377,10 +377,10 @@ private void doBeforeLayout() {
   private void setWidgetVisible(Widget widget, Layer layer, boolean visible) {
     layer.setVisible(visible);
 
-      /*
-       * Set the visibility of the widget. This is used by lazy panel to
-       * initialize the widget.
-       */
+    /*
+     * Set the visibility of the widget. This is used by lazy panel to
+     * initialize the widget.
+     */
     widget.setVisible(visible);
   }
 

server/node/src/main/java/org/kaaproject/kaa/server/admin/client/mvp/activity/AbstractUserActivity.java

@@ -27,8 +27,8 @@
 import org.kaaproject.kaa.server.admin.client.mvp.view.UserView;
 import org.kaaproject.kaa.server.admin.client.util.Utils;
 
-public abstract class AbstractUserActivity<T extends UserDto, V extends UserView, P extends UserPlace> extends
-    AbstractDetailsActivity<T, V, P> {
+public abstract class AbstractUserActivity<T extends UserDto, V extends UserView, P extends
+        UserPlace> extends AbstractDetailsActivity<T, V, P> {
 
 
   public AbstractUserActivity(P place, ClientFactory clientFactory) {
@@ -59,7 +59,8 @@ protected void doSave(final EventBus eventBus) {
     detailsView.clearError();
 
     if (create) {
-      KaaAdmin.getAuthService().checkUserNameOccupied(entity.getUsername(), null, new BusyAsyncCallback<ResultCode>() {
+      KaaAdmin.getAuthService().checkUserNameOccupied(
+              entity.getUsername(), null, new BusyAsyncCallback<ResultCode>() {
         @Override
         public void onFailureImpl(Throwable caught) {
           Utils.handleException(caught, detailsView);
@@ -81,7 +82,8 @@ public void onSuccessImpl(ResultCode result) {
 
   private void checkEmail() {
     final Long userId = !create ? Long.valueOf(entity.getExternalUid()) : null;
-    KaaAdmin.getAuthService().checkEmailOccupied(entity.getMail(), userId, new BusyAsyncCallback<ResultCode>() {
+    KaaAdmin.getAuthService().checkEmailOccupied(
+            entity.getMail(), userId, new BusyAsyncCallback<ResultCode>() {
       @Override
       public void onFailureImpl(Throwable caught) {
         Utils.handleException(caught, detailsView);

server/node/src/main/java/org/kaaproject/kaa/server/admin/client/mvp/activity/CtlSchemaActivity.java

@@ -61,8 +61,9 @@
 import java.util.Collections;
 import java.util.List;
 
-public class CtlSchemaActivity extends AbstractDetailsActivity<CtlSchemaFormDto, CtlSchemaView, CtlSchemaPlace>
-    implements ErrorMessageCustomizer, FormDataLoader {
+public class CtlSchemaActivity extends
+        AbstractDetailsActivity<CtlSchemaFormDto, CtlSchemaView, CtlSchemaPlace>
+        implements ErrorMessageCustomizer, FormDataLoader {
 
   protected static final ErrorMessageCustomizer schemaErrorMessageCustomizer
       = new SchemaErrorMessageCustomizer();

server/node/src/main/java/org/kaaproject/kaa/server/admin/client/mvp/activity/LogAppendersActivity.java

@@ -54,7 +54,8 @@ protected BaseListView<LogAppenderDto> getView() {
   }
 
   @Override
-  protected AbstractDataProvider<LogAppenderDto, String> getDataProvider(AbstractGrid<LogAppenderDto, String> dataGrid) {
+  protected AbstractDataProvider<LogAppenderDto, String> getDataProvider(
+          AbstractGrid<LogAppenderDto, String> dataGrid) {
     return new AppendersDataProvider(dataGrid, listView, applicationId);
   }
 

server/node/src/main/java/org/kaaproject/kaa/server/admin/client/mvp/data/DataSource.java

@@ -304,7 +304,7 @@ protected void onResult(PropertiesDto result) {
   }
 
   /**
-   * Edits general properties
+   * Edits general properties.
    *
    * @param generalProperties new general properties
    * @param callback          callback which should be called with a result
@@ -929,7 +929,7 @@ protected void onResult(CtlSchemaReferenceDto result) {
   }
 
   /**
-   * Adds an event class family version
+   * Adds an event class family version.
    *
    * @param eventClassFamilyId event class family identifier
    * @param eventClassViewDto  event class family view
@@ -1087,7 +1087,7 @@ protected void onResult(List<ServerProfileSchemaDto> result) {
   }
 
   /**
-   * Returns a server profile schema info list
+   * Returns a server profile schema info list.
    *
    * @param applicationId application identifier
    * @param callback      callback which should be called with a result
@@ -1546,7 +1546,7 @@ protected void onResult(List<CTLSchemaMetaInfoDto> result) {
   }
 
   /**
-   * Returns the latest CTL schema form
+   * Returns the latest CTL schema form.
    *
    * @param metaInfoId meta information identifier
    * @param callback   callback which should be called with a result
@@ -1562,7 +1562,7 @@ protected void onResult(CtlSchemaFormDto result) {
   }
 
   /**
-   * Returns the CTL schema form
+   * Returns the CTL schema form.
    *
    * @param metaInfoId meta information identifier
    * @param version    CTL schema version
@@ -1652,7 +1652,7 @@ protected void onResult(Boolean result) {
   }
 
   /**
-   * Promotes a scope
+   * Promotes a scope.
    *
    * @param applicationId application identifier
    * @param fqn           fully qualified name
@@ -1865,14 +1865,14 @@ protected void onResult(EndpointGroupDto result) {
   /**
    * Returns en endpoint profile.
    *
-   * @param groupID  endpoint group identifier
+   * @param groupId  endpoint group identifier
    * @param limit    limit
    * @param offset   offset
    * @param callback callback which should be called with a result
    */
-  public void getEndpointProfileByGroupId(String groupID, String limit, String offset,
+  public void getEndpointProfileByGroupId(String groupId, String limit, String offset,
                                           AsyncCallback<EndpointProfilesPageDto> callback) {
-    groupRpcService.getEndpointProfileByEndpointGroupId(groupID, limit, offset, callback);
+    groupRpcService.getEndpointProfileByEndpointGroupId(groupId, limit, offset, callback);
   }
 
   /**
@@ -2710,7 +2710,7 @@ protected void onResult(Void result) {
   }
 
   /**
-   * Returns the SDK profile
+   * Returns the SDK profile.
    *
    * @param sdkProfileId SDK profile identifier
    * @param callback     callback which should be called with a result

server/node/src/main/java/org/kaaproject/kaa/server/admin/client/mvp/data/UserVerifiersDataProvider.java

@@ -30,6 +30,7 @@
 
 public class UserVerifiersDataProvider extends AbstractDataProvider<UserVerifierDto, String> {
   private String applicationId;
+
   /**
    * All-args constructor.
    */

server/node/src/main/java/org/kaaproject/kaa/server/admin/client/mvp/place/AbstractPluginsPlace.java

@@ -68,7 +68,7 @@ public TreePlaceDataProvider getDataProvider(EventBus eventBus) {
     return null;
   }
 
-  public static abstract class Tokenizer<P extends AbstractPluginsPlace>
+  public abstract static class Tokenizer<P extends AbstractPluginsPlace>
       implements PlaceTokenizer<P>, PlaceConstants {
 
     @Override

server/node/src/main/java/org/kaaproject/kaa/server/admin/client/mvp/place/ApplicationCtlSchemasPlace.java

@@ -54,7 +54,7 @@ public boolean equals(Object obj) {
 
     ApplicationCtlSchemasPlace other = (ApplicationCtlSchemasPlace) obj;
     if (applicationId == null && other.applicationId != null) {
-        return false;
+      return false;
     } else if (!applicationId.equals(other.applicationId)) {
       return false;
     }

server/node/src/main/java/org/kaaproject/kaa/server/admin/client/mvp/place/CtlSchemaPlace.java

@@ -143,7 +143,7 @@ public boolean equals(Object obj) {
     }
 
     if (metaInfoId == null && other.metaInfoId != null) {
-        return false;
+      return false;
     } else if (!metaInfoId.equals(other.metaInfoId)) {
       return false;
     }
@@ -157,7 +157,7 @@ public boolean equals(Object obj) {
     }
 
     if (version == null && other.version != null) {
-        return false;
+      return false;
     } else if (!version.equals(other.version)) {
       return false;
     }

server/node/src/main/java/org/kaaproject/kaa/server/admin/client/mvp/place/EventClassPlace.java

@@ -96,7 +96,8 @@ public int hashCode() {
   public static class Tokenizer extends AbstractSchemaPlaceEvent.Tokenizer<EventClassPlace> {
 
     @Override
-    protected EventClassPlace getPlaceImpl(String ecfId, String ecfVersionId, int ecfVersion, String schemaId) {
+    protected EventClassPlace getPlaceImpl(
+            String ecfId, String ecfVersionId, int ecfVersion, String schemaId) {
       return new EventClassPlace(ecfId, ecfVersionId, ecfVersion, schemaId);
     }
 

server/node/src/main/java/org/kaaproject/kaa/server/admin/client/mvp/view/config/ConfigSchemaGrid.java

@@ -64,24 +64,25 @@ protected float constructActions(DataGrid<ConfigurationSchemaDto> table, float p
   }
 
   private Column<ConfigurationSchemaDto, ConfigurationSchemaDto>
-  constructDownloadBaseSchemaColumnColumn(String text) {
+      constructDownloadBaseSchemaColumnColumn(String text) {
     ActionButtonCell<ConfigurationSchemaDto> cell = new ActionButtonCell<>(
-        Utils.resources.download_grey(), text, embedded,
-        new ActionButtonCell.ActionListener<ConfigurationSchemaDto>() {
-          @Override
-          public void onItemAction(ConfigurationSchemaDto value) {
-            Integer schemaVersion = value.getVersion();
-            RowActionEvent<String> rowDownloadBaseSchemaEvent = new RowActionEvent<>(
+            Utils.resources.download_grey(), text, embedded,
+            new ActionButtonCell.ActionListener<ConfigurationSchemaDto>() {
+        @Override
+        public void onItemAction(ConfigurationSchemaDto value) {
+          Integer schemaVersion = value.getVersion();
+          RowActionEvent<String> rowDownloadBaseSchemaEvent = new RowActionEvent<>(
                 String.valueOf(schemaVersion), KaaRowAction.DOWNLOAD_BASE_SCHEMA);
-            fireEvent(rowDownloadBaseSchemaEvent);
-          }
+          fireEvent(rowDownloadBaseSchemaEvent);
+        }
         }, new ActionButtonCell.ActionValidator<ConfigurationSchemaDto>() {
-      @Override
-      public boolean canPerformAction(ConfigurationSchemaDto value) {
-        return !embedded;
-      }
-    });
-    Column<ConfigurationSchemaDto, ConfigurationSchemaDto> column = new Column<ConfigurationSchemaDto, ConfigurationSchemaDto>(cell) {
+          @Override
+          public boolean canPerformAction(ConfigurationSchemaDto value) {
+            return !embedded;
+          }
+        });
+    Column<ConfigurationSchemaDto, ConfigurationSchemaDto> column =
+            new Column<ConfigurationSchemaDto, ConfigurationSchemaDto>(cell) {
       @Override
       public ConfigurationSchemaDto getValue(ConfigurationSchemaDto item) {
         return item;
@@ -90,26 +91,26 @@ public ConfigurationSchemaDto getValue(ConfigurationSchemaDto item) {
     return column;
   }
 
-
   private Column<ConfigurationSchemaDto, ConfigurationSchemaDto>
-  constructDownloadOverrideSchemaColumnColumn(String text) {
+      constructDownloadOverrideSchemaColumnColumn(String text) {
     ActionButtonCell<ConfigurationSchemaDto> cell = new ActionButtonCell<>(
-        Utils.resources.download_grey(), text, embedded,
-        new ActionButtonCell.ActionListener<ConfigurationSchemaDto>() {
-          @Override
-          public void onItemAction(ConfigurationSchemaDto value) {
-            Integer schemaVersion = value.getVersion();
-            RowActionEvent<String> rowDownloadOverrideSchemaEvent = new RowActionEvent<>(
+            Utils.resources.download_grey(), text, embedded,
+            new ActionButtonCell.ActionListener<ConfigurationSchemaDto>() {
+        @Override
+        public void onItemAction(ConfigurationSchemaDto value) {
+          Integer schemaVersion = value.getVersion();
+          RowActionEvent<String> rowDownloadOverrideSchemaEvent = new RowActionEvent<>(
                 String.valueOf(schemaVersion), KaaRowAction.DOWNLOAD_OVERRIDE_SCHEMA);
-            fireEvent(rowDownloadOverrideSchemaEvent);
-          }
-        }, new ActionButtonCell.ActionValidator<ConfigurationSchemaDto>() {
-      @Override
-      public boolean canPerformAction(ConfigurationSchemaDto value) {
-        return !embedded;
-      }
-    });
-    Column<ConfigurationSchemaDto, ConfigurationSchemaDto> column = new Column<ConfigurationSchemaDto, ConfigurationSchemaDto>(cell) {
+          fireEvent(rowDownloadOverrideSchemaEvent);
+        }
+      }, new ActionButtonCell.ActionValidator<ConfigurationSchemaDto>() {
+        @Override
+        public boolean canPerformAction(ConfigurationSchemaDto value) {
+          return !embedded;
+        }
+      });
+    Column<ConfigurationSchemaDto, ConfigurationSchemaDto> column =
+            new Column<ConfigurationSchemaDto, ConfigurationSchemaDto>(cell) {
       @Override
       public ConfigurationSchemaDto getValue(ConfigurationSchemaDto item) {
         return item;

server/node/src/main/java/org/kaaproject/kaa/server/admin/client/mvp/view/dialog/ResetPasswordDialog.java

@@ -93,12 +93,12 @@ public void onInputChanged(InputEvent event) {
     dialogContents.add(table);
 
     sendResetPasswordLinkButton = new Button(
-        Utils.constants.sendResetPasswordLink(), new ClickHandler() {
-      @Override
-      public void onClick(ClickEvent event) {
-        validateUsernameOrEmail();
-      }
-    });
+            Utils.constants.sendResetPasswordLink(), new ClickHandler() {
+              @Override
+              public void onClick(ClickEvent event) {
+                validateUsernameOrEmail();
+              }
+            });
 
     Button cancelButton = new Button(Utils.constants.cancel(), new ClickHandler() {
       @Override

server/node/src/main/java/org/kaaproject/kaa/server/admin/client/mvp/view/enduser/UpdateUserConfigViewImpl.java

@@ -69,8 +69,8 @@ public void onValueChange(ValueChangeEvent<SchemaInfoDto> event) {
 
     getFooter().addStyleName(Utils.kaaAdminStyle.bAppContentDetailsTable());
 
-    configurationData = new RecordPanel(new AvroWidgetsConfig.Builder().
-        recordPanelWidth(900)
+    configurationData = new RecordPanel(new AvroWidgetsConfig.Builder()
+        .recordPanelWidth(900)
         .gridHeight(250)
         .tableHeight(230)
         .createConfig(),

server/node/src/main/java/org/kaaproject/kaa/server/admin/client/mvp/view/event/EventMapGrid.java

@@ -94,7 +94,8 @@ public ApplicationEventAction getValue(ApplicationEventMapDto object) {
       actionColumn.setFieldUpdater(
           new FieldUpdater<ApplicationEventMapDto, ApplicationEventAction>() {
             @Override
-            public void update(int index, ApplicationEventMapDto object, ApplicationEventAction value) {
+            public void update(int index, ApplicationEventMapDto object,
+                               ApplicationEventAction value) {
               object.setAction(value);
             }
           });

server/node/src/main/java/org/kaaproject/kaa/server/admin/client/mvp/view/log/LogSchemaGrid.java

@@ -78,11 +78,11 @@ public void onItemAction(LogSchemaDto value) {
             fireEvent(rowDownloadLibraryEvent);
           }
         }, new ActionValidator<LogSchemaDto>() {
-      @Override
-      public boolean canPerformAction(LogSchemaDto value) {
-        return !embedded;
-      }
-    });
+          @Override
+          public boolean canPerformAction(LogSchemaDto value) {
+            return !embedded;
+          }
+        });
     Column<LogSchemaDto, LogSchemaDto> column = new Column<LogSchemaDto, LogSchemaDto>(cell) {
       @Override
       public LogSchemaDto getValue(LogSchemaDto item) {

server/node/src/main/java/org/kaaproject/kaa/server/admin/client/mvp/view/plugin/BasePluginGrid.java

@@ -89,11 +89,11 @@ public void onItemAction(T value) {
             fireEvent(rowDownloadSchemaEvent);
           }
         }, new ActionButtonCell.ActionValidator<T>() {
-      @Override
-      public boolean canPerformAction(T value) {
-        return !embedded;
-      }
-    });
+            @Override
+            public boolean canPerformAction(T value) {
+                return !embedded;
+            }
+            });
     Column<T, T> column = new Column<T, T>(cell) {
       @Override
       public T getValue(T item) {