Skip to content

Commit

Permalink
Fixed about 150 warns.
Browse files Browse the repository at this point in the history
  • Loading branch information
Acarus committed Oct 3, 2016
1 parent 1896f96 commit a8ef067
Show file tree
Hide file tree
Showing 109 changed files with 611 additions and 206 deletions.
Expand Up @@ -58,10 +58,16 @@ public class AndroidSqLiteDqLogStorage implements LogStorage, LogStorageStatus {
private SQLiteStatement updateBucketStateStatement; private SQLiteStatement updateBucketStateStatement;
private SQLiteStatement resetBucketIdStatement; private SQLiteStatement resetBucketIdStatement;


/**
* Instantiates the AndroidSqLiteDqLogStorage.
*/
public AndroidSqLiteDqLogStorage(Context context, long maxBucketSize, int maxRecordCount) { public AndroidSqLiteDqLogStorage(Context context, long maxBucketSize, int maxRecordCount) {
this(context, PersistentLogStorageConstants.DEFAULT_DB_NAME, maxBucketSize, maxRecordCount); this(context, PersistentLogStorageConstants.DEFAULT_DB_NAME, maxBucketSize, maxRecordCount);
} }


/**
* Instantiates the AndroidSqLiteDqLogStorage.
*/
public AndroidSqLiteDqLogStorage(Context context, String dbName, long bucketSize, public AndroidSqLiteDqLogStorage(Context context, String dbName, long bucketSize,
int recordCount) { int recordCount) {
Log.i(TAG, "Connecting to db with name: " + dbName); Log.i(TAG, "Connecting to db with name: " + dbName);
Expand Down Expand Up @@ -245,8 +251,8 @@ public void removeBucket(int recordBlockId) {


if (removedRecordsCount > 0) { if (removedRecordsCount > 0) {
totalRecordCount -= removedRecordsCount; totalRecordCount -= removedRecordsCount;
Log.i(TAG, "Removed " + removedRecordsCount + Log.i(TAG, "Removed " + removedRecordsCount
" records from storage. Total log record count: " + totalRecordCount); + " records from storage. Total log record count: " + totalRecordCount);
} else { } else {
Log.i(TAG, "No records were removed from storage"); Log.i(TAG, "No records were removed from storage");
} }
Expand Down
Expand Up @@ -28,6 +28,9 @@ public class ByteArrayBody extends AbstractContentBody {


private final String filename; private final String filename;


/**
* All-args constructor.
*/
public ByteArrayBody(final byte[] data, final String mimeType, final String filename) { public ByteArrayBody(final byte[] data, final String mimeType, final String filename) {
super(mimeType); super(mimeType);
if (data == null) { if (data == null) {
Expand Down
Expand Up @@ -104,6 +104,11 @@ private static void checkNotBlankProperty(String fileName, String errorMessage)
} }
} }


/**
* Calculates a hash for SDK properties.
*
* @return hash for SDK properties
*/
public byte[] getPropertiesHash() { public byte[] getPropertiesHash() {
if (propertiesHash == null) { if (propertiesHash == null) {
try { try {
Expand Down
Expand Up @@ -65,6 +65,9 @@ public class DefaultBootstrapManager implements BootstrapManager {
private Integer serverToApply; private Integer serverToApply;
private ExecutorContext executorContext; private ExecutorContext executorContext;


/**
* All-args constructor.
*/
public DefaultBootstrapManager(BootstrapTransport transport, ExecutorContext executorContext, public DefaultBootstrapManager(BootstrapTransport transport, ExecutorContext executorContext,
FailureListener failureListener) { FailureListener failureListener) {
this.transport = transport; this.transport = transport;
Expand Down
Expand Up @@ -30,6 +30,9 @@ public class GenericTransportInfo implements TransportConnectionInfo {
protected final TransportProtocolId transportId; protected final TransportProtocolId transportId;
protected final ProtocolMetaData md; protected final ProtocolMetaData md;


/**
* All-args constructor.
*/
public GenericTransportInfo(ServerType serverType, ProtocolMetaData md) { public GenericTransportInfo(ServerType serverType, ProtocolMetaData md) {
super(); super();
this.serverType = serverType; this.serverType = serverType;
Expand Down
Expand Up @@ -36,6 +36,9 @@ public class IpTransportInfo extends GenericTransportInfo {
private final int port; private final int port;
private final PublicKey publicKey; private final PublicKey publicKey;


/**
* All-args constructor.
*/
public IpTransportInfo(TransportConnectionInfo parent) { public IpTransportInfo(TransportConnectionInfo parent) {
super(parent.getServerType(), new ProtocolMetaData(parent.getAccessPointId(), super(parent.getServerType(), new ProtocolMetaData(parent.getAccessPointId(),
new ProtocolVersionPair(parent.getTransportId() new ProtocolVersionPair(parent.getTransportId()
Expand Down
Expand Up @@ -27,6 +27,9 @@ public final class TransportProtocolId {
private final int id; private final int id;
private final int version; private final int version;


/**
* All-args constructor.
*/
public TransportProtocolId(int protocolId, int protocolVersion) { public TransportProtocolId(int protocolId, int protocolVersion) {
super(); super();
this.id = protocolId; this.id = protocolId;
Expand Down
Expand Up @@ -48,6 +48,9 @@ public DefaultFailoverManager(KaaChannelManager channelManager, ExecutorContext
DEFAULT_FAILURE_RESOLUTION_TIMEOUT, DEFAULT_TIME_UNIT); DEFAULT_FAILURE_RESOLUTION_TIMEOUT, DEFAULT_TIME_UNIT);
} }


/**
* All-args constructor.
*/
public DefaultFailoverManager(KaaChannelManager channelManager, public DefaultFailoverManager(KaaChannelManager channelManager,
ExecutorContext context, ExecutorContext context,
FailoverStrategy failoverStrategy, FailoverStrategy failoverStrategy,
Expand Down
Expand Up @@ -33,6 +33,9 @@ public FailoverDecision(FailoverAction action) {
this.action = action; this.action = action;
} }


/**
* All-args constructor.
*/
public FailoverDecision(FailoverAction action, long retryPeriod, TimeUnit timeUnit) { public FailoverDecision(FailoverAction action, long retryPeriod, TimeUnit timeUnit) {
this.action = action; this.action = action;
this.retryPeriod = retryPeriod; this.retryPeriod = retryPeriod;
Expand Down
Expand Up @@ -42,13 +42,19 @@ public class DefaultFailoverStrategy implements FailoverStrategy {
private long noConnectivityRetryPeriod; private long noConnectivityRetryPeriod;
private TimeUnit timeUnit; private TimeUnit timeUnit;


/**
* Instantiates the DelautFailoverStrategy.
*/
public DefaultFailoverStrategy() { public DefaultFailoverStrategy() {
this(DEFAULT_BOOTSTRAP_SERVERS_RETRY_PERIOD, this(DEFAULT_BOOTSTRAP_SERVERS_RETRY_PERIOD,
DEFAULT_OPERATION_SERVERS_RETRY_PERIOD, DEFAULT_OPERATION_SERVERS_RETRY_PERIOD,
DEFAULT_NO_CONNECTIVITY_RETRY_PERIOD, DEFAULT_NO_CONNECTIVITY_RETRY_PERIOD,
DEFAULT_TIME_UNIT); DEFAULT_TIME_UNIT);
} }


/**
* All-args constructor.
*/
public DefaultFailoverStrategy(long bootstrapServersRetryPeriod, public DefaultFailoverStrategy(long bootstrapServersRetryPeriod,
long operationsServersRetryPeriod, long operationsServersRetryPeriod,
long noConnectivityRetryPeriod, long noConnectivityRetryPeriod,
Expand Down
Expand Up @@ -72,6 +72,9 @@ public class DefaultChannelManager implements KaaInternalChannelManager {
private KaaDataMultiplexer bootstrapMultiplexer; private KaaDataMultiplexer bootstrapMultiplexer;
private KaaDataDemultiplexer bootstrapDemultiplexer; private KaaDataDemultiplexer bootstrapDemultiplexer;


/**
* All-args constructor.
*/
public DefaultChannelManager(BootstrapManager manager, Map<TransportProtocolId, public DefaultChannelManager(BootstrapManager manager, Map<TransportProtocolId,
List<TransportConnectionInfo>> bootststrapServers, ExecutorContext executorContext, List<TransportConnectionInfo>> bootststrapServers, ExecutorContext executorContext,
FailureListener failureListener) { FailureListener failureListener) {
Expand Down
Expand Up @@ -61,6 +61,9 @@ public abstract class AbstractHttpChannel implements KaaDataChannel {
private KaaDataDemultiplexer demultiplexer; private KaaDataDemultiplexer demultiplexer;
private KaaDataMultiplexer multiplexer; private KaaDataMultiplexer multiplexer;


/**
* All-args constructor.
*/
public AbstractHttpChannel(AbstractKaaClient client, KaaClientState state, public AbstractHttpChannel(AbstractKaaClient client, KaaClientState state,
FailoverManager failoverManager) { FailoverManager failoverManager) {
this.client = client; this.client = client;
Expand Down
Expand Up @@ -215,6 +215,9 @@ public void run() {
} }
}; };


/**
* All-args constructor.
*/
public DefaultOperationTcpChannel(KaaClientState state, FailoverManager failoverManager, public DefaultOperationTcpChannel(KaaClientState state, FailoverManager failoverManager,
FailureListener failureListener) { FailureListener failureListener) {
this.state = state; this.state = state;
Expand Down
Expand Up @@ -115,6 +115,9 @@ protected void executeCommand() {
private volatile boolean isShutdown = false; private volatile boolean isShutdown = false;
private volatile boolean isPaused = false; private volatile boolean isPaused = false;


/**
* All-args constructor.
*/
public DefaultOperationsChannel(AbstractKaaClient client, KaaClientState state, public DefaultOperationsChannel(AbstractKaaClient client, KaaClientState state,
FailoverManager failoverManager) { FailoverManager failoverManager) {
this.client = client; this.client = client;
Expand Down
Expand Up @@ -37,6 +37,9 @@ public void run() {
} }
} }


/**
* Waits until a command executed.
*/
public void waitUntilExecuted() { public void waitUntilExecuted() {
while (isRunning) { while (isRunning) {
synchronized (this) { synchronized (this) {
Expand Down
Expand Up @@ -37,6 +37,9 @@ public class PollCommand implements Command {
private final IpTransportInfo serverInfo; private final IpTransportInfo serverInfo;
private volatile boolean canceled = false; private volatile boolean canceled = false;


/**
* All-args constructor.
*/
public PollCommand(AbstractHttpClient client, RawDataProcessor processor, Map<TransportType, public PollCommand(AbstractHttpClient client, RawDataProcessor processor, Map<TransportType,
ChannelDirection> transportTypes, IpTransportInfo serverInfo) { ChannelDirection> transportTypes, IpTransportInfo serverInfo) {
this.httpClient = client; this.httpClient = client;
Expand Down
Expand Up @@ -28,19 +28,32 @@ public class SyncTask {
private final boolean ackOnly; private final boolean ackOnly;
private final boolean all; private final boolean all;


/**
* Instantiates the SyncTask.
*/
public SyncTask(TransportType type, boolean ackOnly, boolean all) { public SyncTask(TransportType type, boolean ackOnly, boolean all) {
this(Collections.singleton(type), ackOnly, all); this(Collections.singleton(type), ackOnly, all);
} }


/**
* Instantiates the SyncTask.
*/
public SyncTask(Set<TransportType> types, boolean ackOnly, boolean all) { public SyncTask(Set<TransportType> types, boolean ackOnly, boolean all) {
super(); super();
this.types = types; this.types = types;
this.ackOnly = ackOnly; this.ackOnly = ackOnly;
this.all = all; this.all = all;
} }


/**
* Merges sync tasks.
*
* @param syncTask sync task
* @param additionalTasks additional sync tasks
* @return merged sync task
*/
public static SyncTask merge(SyncTask syncTask, List<SyncTask> additionalTasks) { public static SyncTask merge(SyncTask syncTask, List<SyncTask> additionalTasks) {
Set<TransportType> types = new HashSet<TransportType>(); Set<TransportType> types = new HashSet<>();
types.addAll(syncTask.types); types.addAll(syncTask.types);
boolean ack = syncTask.ackOnly; boolean ack = syncTask.ackOnly;
boolean all = syncTask.all; boolean all = syncTask.all;
Expand Down
Expand Up @@ -45,6 +45,9 @@ public abstract class AbstractConfigurationManager implements ConfigurationManag
private ConfigurationHashContainer container = new HashContainer(); private ConfigurationHashContainer container = new HashContainer();
private KaaClientState state; private KaaClientState state;


/**
* All-args constructor.
*/
public AbstractConfigurationManager(KaaClientProperties properties, KaaClientState state, public AbstractConfigurationManager(KaaClientProperties properties, KaaClientState state,
ExecutorContext executorContext) { ExecutorContext executorContext) {
super(); super();
Expand Down
Expand Up @@ -48,6 +48,9 @@ public SimpleExecutorContext() {
this(SINGLE_THREAD, SINGLE_THREAD, SINGLE_THREAD, SINGLE_THREAD); this(SINGLE_THREAD, SINGLE_THREAD, SINGLE_THREAD, SINGLE_THREAD);
} }


/**
* All-args constructor.
*/
public SimpleExecutorContext(int lifeCycleThreadCount, int apiThreadCount, public SimpleExecutorContext(int lifeCycleThreadCount, int apiThreadCount,
int callbackThreadCount, int scheduledThreadCount) { int callbackThreadCount, int scheduledThreadCount) {
super(); super();
Expand Down
Expand Up @@ -43,6 +43,9 @@ public final class TransportContext {
private final RedirectionTransport redirectionTransport; private final RedirectionTransport redirectionTransport;
private final LogTransport logTransport; private final LogTransport logTransport;


/**
* All-args constructor.
*/
public TransportContext(MetaDataTransport mdTransport, BootstrapTransport bootstrapTransport, public TransportContext(MetaDataTransport mdTransport, BootstrapTransport bootstrapTransport,
ProfileTransport profileTransport, EventTransport eventTransport, ProfileTransport profileTransport, EventTransport eventTransport,
NotificationTransport notificationTransport, NotificationTransport notificationTransport,
Expand Down Expand Up @@ -97,6 +100,12 @@ public LogTransport getLogTransport() {
return logTransport; return logTransport;
} }


/**
* Initialize transports.
*
* @param channelManager channel manager
* @param clientState kaa client state
*/
public void initTransports(KaaChannelManager channelManager, KaaClientState clientState) { public void initTransports(KaaChannelManager channelManager, KaaClientState clientState) {
for (KaaTransport transport : Arrays.asList(bootstrapTransport, profileTransport, for (KaaTransport transport : Arrays.asList(bootstrapTransport, profileTransport,
eventTransport, notificationTransport, configurationTransport, userTransport, eventTransport, notificationTransport, configurationTransport, userTransport,
Expand Down
Expand Up @@ -58,6 +58,9 @@ public class DefaultEventManager implements EventManager {
private final Map<TransactionId, List<Event>> transactions = new HashMap<>(); private final Map<TransactionId, List<Event>> transactions = new HashMap<>();
private Boolean isEngaged = false; private Boolean isEngaged = false;


/**
* All-args constructor.
*/
public DefaultEventManager(KaaClientState state, ExecutorContext executorContext, public DefaultEventManager(KaaClientState state, ExecutorContext executorContext,
EventTransport transport) { EventTransport transport) {
this.state = state; this.state = state;
Expand Down
Expand Up @@ -68,6 +68,9 @@ public class DefaultEndpointRegistrationManager implements EndpointRegistrationM
private volatile UserTransport userTransport; private volatile UserTransport userTransport;
private volatile ProfileTransport profileTransport; private volatile ProfileTransport profileTransport;


/**
* All-args constructor.
*/
public DefaultEndpointRegistrationManager(KaaClientState state, ExecutorContext executorContext, public DefaultEndpointRegistrationManager(KaaClientState state, ExecutorContext executorContext,
UserTransport userTransport, UserTransport userTransport,
ProfileTransport profileTransport) { ProfileTransport profileTransport) {
Expand All @@ -88,6 +91,12 @@ private String regenerateEndpointAccessToken() {
return newEndpointAccessToken; return newEndpointAccessToken;
} }



/**
* Updates an endpoint access token.
*
* @param token new endpoint access token
*/
public void updateEndpointAccessToken(String token) { public void updateEndpointAccessToken(String token) {
state.setEndpointAccessToken(token); state.setEndpointAccessToken(token);
state.setIfNeedProfileResync(true); state.setIfNeedProfileResync(true);
Expand Down
Expand Up @@ -66,6 +66,9 @@ public abstract class AbstractLogCollector implements LogCollector, LogProcessor
private LogDeliveryListener logDeliveryListener; private LogDeliveryListener logDeliveryListener;
private boolean uploadCheckInProgress = false; private boolean uploadCheckInProgress = false;


/**
* All-args constructor.
*/
public AbstractLogCollector(LogTransport transport, ExecutorContext executorContext, public AbstractLogCollector(LogTransport transport, ExecutorContext executorContext,
KaaChannelManager channelManager, FailoverManager failoverManager) { KaaChannelManager channelManager, FailoverManager failoverManager) {
this.strategy = new DefaultLogUploadStrategy(); this.strategy = new DefaultLogUploadStrategy();
Expand Down
Expand Up @@ -21,6 +21,9 @@ public class ExecutionResult<T> {
private final T obj; private final T obj;
private final Exception ex; private final Exception ex;


/**
* All-args constructor.
*/
public ExecutionResult(T obj, Exception ex) { public ExecutionResult(T obj, Exception ex) {
super(); super();
this.obj = obj; this.obj = obj;
Expand Down
Expand Up @@ -88,6 +88,12 @@ public boolean equals(Object obj) {
return true; return true;
} }


/**
* Sets value.
*
* @param value value
* @param arriveTime arrive time
*/
public void setValue(RecordInfo value, Long arriveTime) { public void setValue(RecordInfo value, Long arriveTime) {
try { try {
value.setRecordAddedTimestampMs(recordAddedTimestampMs); value.setRecordAddedTimestampMs(recordAddedTimestampMs);
Expand Down
Expand Up @@ -33,6 +33,9 @@ public class MemBucket {
protected long size; protected long size;
private MemBucketState state; private MemBucketState state;


/**
* All-args constructor.
*/
public MemBucket(int id, long maxSize, int maxRecordCount) { public MemBucket(int id, long maxSize, int maxRecordCount) {
super(); super();
this.id = id; this.id = id;
Expand Down Expand Up @@ -66,6 +69,12 @@ public void setState(MemBucketState state) {
this.state = state; this.state = state;
} }


/**
* Adds a record to a bucket.
*
* @param record record
* @return true if record is added otherwise false
*/
public boolean addRecord(LogRecord record) { public boolean addRecord(LogRecord record) {
if (size + record.getSize() > maxSize) { if (size + record.getSize() > maxSize) {
LOG.trace("No space left in bucket. Current size: {}, record size: {}, max size: {}", LOG.trace("No space left in bucket. Current size: {}, record size: {}, max size: {}",
Expand Down
Expand Up @@ -54,6 +54,9 @@ public MemLogStorage(long bucketSize, int bucketRecordCount) {
this(DEFAULT_MAX_STORAGE_SIZE, bucketSize, bucketRecordCount); this(DEFAULT_MAX_STORAGE_SIZE, bucketSize, bucketRecordCount);
} }


/**
* All-args constructor.
*/
public MemLogStorage(long maxStorageSize, long bucketSize, int bucketRecordCount) { public MemLogStorage(long maxStorageSize, long bucketSize, int bucketRecordCount) {
super(); super();
this.maxStorageSize = maxStorageSize; this.maxStorageSize = maxStorageSize;
Expand Down
Expand Up @@ -55,6 +55,9 @@ public class DefaultNotificationManager implements NotificationManager, Notifica
private Map<Long, Topic> topics = new HashMap<>(); private Map<Long, Topic> topics = new HashMap<>();
private volatile NotificationTransport transport; private volatile NotificationTransport transport;


/**
* All-args constructor.
*/
public DefaultNotificationManager(KaaClientState state, ExecutorContext executorContext, public DefaultNotificationManager(KaaClientState state, ExecutorContext executorContext,
NotificationTransport transport) { NotificationTransport transport) {
this.state = state; this.state = state;
Expand Down
Expand Up @@ -43,6 +43,9 @@ public DesktopKaaPlatformContext(KaaClientProperties properties) {
this(properties, new SimpleExecutorContext()); this(properties, new SimpleExecutorContext());
} }


/**
* All-args constructor.
*/
public DesktopKaaPlatformContext( public DesktopKaaPlatformContext(
KaaClientProperties properties, ExecutorContext executorContext) { KaaClientProperties properties, ExecutorContext executorContext) {
super(); super();
Expand Down
Expand Up @@ -48,6 +48,9 @@ public class DesktopHttpClient extends AbstractHttpClient {
private CloseableHttpClient httpClient; private CloseableHttpClient httpClient;
private volatile HttpPost method; private volatile HttpPost method;


/**
* All-args constructor.
*/
public DesktopHttpClient(String url, PrivateKey privateKey, public DesktopHttpClient(String url, PrivateKey privateKey,
PublicKey publicKey, PublicKey remotePublicKey) { PublicKey publicKey, PublicKey remotePublicKey) {
super(url, privateKey, publicKey, remotePublicKey); super(url, privateKey, publicKey, remotePublicKey);
Expand Down

0 comments on commit a8ef067

Please sign in to comment.