Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OOTB log4j-config.xml and gateway-config.xml improvements are needed (does not document MaxBackupIndex, etc) #709

Closed
3 tasks done
cmebarrow opened this issue Sep 15, 2016 · 2 comments
Closed
3 tasks done

OOTB log4j-config.xml and gateway-config.xml improvements are needed (does not document MaxBackupIndex, etc) #709

cmebarrow opened this issue Sep 15, 2016 · 2 comments
Assignees
@cmebarrow
Labels
bug
Milestone
S22 - 16

Comments

@cmebarrow
Copy link
Contributor

cmebarrow commented Sep 15, 2016 •
edited

Our OOTB log4j-config.xml file needs some improvements:

  • remove obsolete definition: appender EventsFile.
  • document MaxBackupIndex in comments in the appender definitions using RollingFileAppender (as pointed out in ticket#68)
  • in order to facilitate use of Identity Logging, we should add the element to the element inside in our OOTB gateway-config.xml file:
\<security>
...
   <realm>
     <name>demo</name>
     <description>Sample realm for file-based authentication</description>

     <!-- Include user name in log messages and make visible in JMX beans -->
     <user-principal-class>
        org.kaazing.gateway.security.auth.config.UserConfig
     </user-principal-class>

     <authentication>
       <http-challenge-scheme>Application Basic</http-challenge-scheme>
...

(see also issue #773)
@cmebarrow cmebarrow changed the title OOTB log4j-config.xml file has obsolete content and does not document MaxBackupIndex OOTB log4j-config.xml file improvements needed (does not document MaxBackupIndex, etc) Sep 22, 2016
cmebarrow pushed a commit to cmebarrow/gateway that referenced this issue Sep 23, 2016
(kaazing#709) Added commented out MaxBackupIndex parameter to the app…
ea23cb1 
…enders in the OOTB log4j-config.xml.
cmebarrow pushed a commit to cmebarrow/gateway that referenced this issue Oct 13, 2016
(kaazing#709) Finished adding commented out MaxBackupIndex parameter …
5128df1 
…to the appenders in the OOTB log4j-config.xml. Removed a temporary line added to WsxAcceptorLoggingIT which was causing build failures.
@cmebarrow cmebarrow added this to the S21 - 16 milestone Oct 19, 2016
@sbadugu sbadugu modified the milestones: S22 - 16, S21 - 16 Oct 25, 2016
@cmebarrow cmebarrow mentioned this issue Nov 3, 2016
Closed
@sbadugu sbadugu added the bug label Nov 4, 2016
@cmebarrow cmebarrow changed the title OOTB log4j-config.xml file improvements needed (does not document MaxBackupIndex, etc) OOTB log4j-config.xml and gateway-config.xml improvements are needed (does not document MaxBackupIndex, etc) Nov 4, 2016
@cmebarrow cmebarrow mentioned this issue Nov 4, 2016
Merged
@cmebarrow
Copy link
Contributor Author

@sbadugu @robinzimmermann Robin wants to make sure we bump the minor release version (2nd version digit) for this since if customers uptake the updated OOTB log4j-config.xml they will see a change in behavior (no more access.log and proxy.log files generated, up to 2 error.log.x files up to 50MB each instead of a single one up to 10MB).

@cmebarrow
Copy link
Contributor Author

Closing, fixed by PR #779

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmebarrow cmebarrow

Labels
bug
Projects
None yet
Milestone
S22 - 16
Development

No branches or pull requests
2 participants
@cmebarrow @sbadugu