Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quoted types #2

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Remove quoted types #2

merged 2 commits into from
Jul 27, 2022

Conversation

jwavoet
Copy link
Contributor

@jwavoet jwavoet commented Apr 15, 2022

Code Review

Please consider the following checklist when reviewing this Pull Request.
More background and details here.

  • Does the code actually solve the problem it was meant to solve?
  • Is the code covered by unit tests? Integration tests?
  • Does anything here need documentation? (Focus on why, not what.)
  • Does any of this code deal with privacy sensitive information or affects security? Ask an additional reviewer.
  • Is the code easy to understand and change in the future?
  • Is the same code or concept duplicated? Find a balance between DRYness and readability.
  • Does the code reasonably adhere to the Kabisa coding standards?
  • Be kind.

@jwavoet jwavoet added the enhancement New feature or request label Apr 15, 2022
@jwavoet jwavoet self-assigned this Apr 15, 2022
Copy link
Contributor

@pvlierop pvlierop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look good to me.

This was necessary for 0.11 and earlier.

Now the quotes can be removed.

@JoostSaanen
Copy link
Member

Type is not really needed here, because string is the default

@pvlierop
Copy link
Contributor

Removal is also fine by me.
The issue is that this fix needs to be merged and released so it can be used with current versions of terraform.

@pvlierop pvlierop merged commit 373affa into master Jul 27, 2022
@Glaaj Glaaj deleted the remove-quoted-types branch July 27, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants