Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception thrown in notifier when value is updated after dispose() #49

Merged
merged 3 commits into from Jan 26, 2024

Conversation

kaboc
Copy link
Owner

@kaboc kaboc commented Jan 26, 2024

Fixes #48

@kaboc kaboc self-assigned this Jan 26, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f8e2281) 99.75% compared to head (9df9f89) 99.75%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   99.75%   99.75%   -0.01%     
==========================================
  Files          16       16              
  Lines         820      819       -1     
==========================================
- Hits          818      817       -1     
  Misses          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaboc kaboc merged commit 836eeaf into main Jan 26, 2024
3 checks passed
@kaboc kaboc deleted the fix-notifier-exception branch January 26, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled Exception when parsing completes after CustomTextSpanNotifier.disposed()
1 participant