Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: GetAntlrJar fails to locate jar file on (some?) *nix systems #13

Closed
mrfootoyou opened this issue Jan 3, 2021 · 0 comments
Closed

Comments

@mrfootoyou
Copy link
Contributor

The GetAntlrJar task fails to locate the Antlr .jar file when compiling on *nix systems, specifically Ubuntu and MacOS.

  • Antlr4BuildTasks 8.9
  • Ubuntu 18.04, 20.04, MacOS 10.15 (Github workers)
  • .NET 3.1, 5.0

I've created a repo which demonstrates the error via Github actions. This run shows the build failure and its proximate cause: System.IO.File.Exists(uri.LocalPath) returns false. You can also view the detailed build output here. Also note that the attempts to download the package directly from maven all failed. I'm not sure if that is expected or not. Perhaps the same error is preventing the downloaded files from being detected??

Unfortunately I don't know enough about *nix systems to offer a specific solution to the problem, but I would recommend that you allow the user to specify the UsingToolPath via an optional MSBuild parameter -- had this existed I could have manually computed the correct path as a workaround.

On a related topic, it might be a good idea to use the JAVA_HOME environment variable, if defined, for UsingJavaExec instead of hardcoding it to /usr/bin/java. Also allow the user to override the path via an optional MSBuild parameter just in case.

@kaby76 kaby76 closed this as completed in 587bd10 Jan 5, 2021
kaby76 added a commit to kaby76/Trash that referenced this issue Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant