Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust some definition places in kernel-common & To robust attributes in Struct #3

Closed
wants to merge 7 commits into from
Closed

Adjust some definition places in kernel-common & To robust attributes in Struct #3

wants to merge 7 commits into from

Commits on Nov 16, 2012

  1. Adjust definition place of Enumerator#initialize 

    Before
-------
enumerator.rb: define
enumerator18.rb: none
enumerator19.rb: define

After
-----
enumerator.rb: none
enumerator18.rb: define
enumerator19.rb: define
    @kachick
    kachick committed Nov 16, 2012
    Configuration menu
    Copy the full SHA
    d42572e View commit details
    Browse the repository at this point in the history

  2. Remove disused definition of ConstantScope#const_defined? 

    Before
------
constant_scope.rb: define
constant_scope18.rb: define
constant_scope19.rb: define

After
-----
constant_scope.rb: none
constant_scope18.rb: define
constant_scope19.rb: define
    @kachick
    kachick committed Nov 16, 2012
    Configuration menu
    Copy the full SHA
    7e1b7e1 View commit details
    Browse the repository at this point in the history

  3. Fix coding style of inserting blank lines in Struct

    @kachick
    kachick committed Nov 16, 2012
    Configuration menu
    Copy the full SHA
    a7af28b View commit details
    Browse the repository at this point in the history

  4. Improve Struct.#members 

    * Adjust definition place of Struct.#members
* Improve converting type for own version

Before
------
struct.rb: define
struct18.rb: none
struct19.rb: define

After
-----
struct.rb: define
struct18.rb: none
struct19.rb: none

Thanks for the pointing out.
----------------------------
* #3 (comment)
* bbe2d55
* 4774b58
    @kachick
    kachick committed Nov 16, 2012
    Configuration menu
    Copy the full SHA
    9f5e204 View commit details
    Browse the repository at this point in the history

  5. Freeze Struct::STRUCT_ATTRS 

    For prevent to break inner data structures.
    @kachick
    kachick committed Nov 16, 2012
    Configuration menu
    Copy the full SHA
    c4980e4 View commit details
    Browse the repository at this point in the history

  6. Modify visibility of Struct#_attrs, "public" to "private" 

    This is a private method.
Because accessing inner data structures.
    @kachick
    kachick committed Nov 16, 2012
    Configuration menu
    Copy the full SHA
    ba0b9a8 View commit details
    Browse the repository at this point in the history

  7. Use Struct#_attrs in Struct#initialize 

    For get consistency of coding in Struct.
    @kachick
    kachick committed Nov 16, 2012
    Configuration menu
    Copy the full SHA
    5183c3c View commit details
    Browse the repository at this point in the history