Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024-03-05 - なんで GitHub Action ではJavaScript Action が好まれているのかわかってない #271

Open
kachick opened this issue Mar 5, 2024 · 1 comment
Labels
question Further information is requested

Comments

@kachick
Copy link
Owner

kachick commented Mar 5, 2024

https://docs.github.com/en/actions/creating-actions

docker container, javascript, composite と 3つ action 種別が有る。docker action は ameba が使ってて https://github.com/crystal-ameba/github-action/blob/8039cc4889f60fb72be76fdcd34a0bf281b8e1d9/action.yml#L5 起動までむちゃ重かったしまぁなんとなく想像つくけど、composite で任意のツール入れて処理入れれば別に javascript action で書かないでも良いのではないか

と思ったんだけど実際のとこどうなんだろう。前に一度 composite action 書いた時に色々ハマった気もするけど、何かが実現できないみたいな制約はなかった気もする・・・ #13 (comment)

普段遣いの action だと dprint check が composite https://github.com/dprint/check/blob/2f1cf31537886c3bfb05591c031f7744e48ba8a1/action.yml#L14

@kachick kachick added the question Further information is requested label Mar 5, 2024
@kachick
Copy link
Owner Author

kachick commented Apr 5, 2024

Linux, macOS, Windows といった runner それぞれで同じコードを動かせるから

的な話だったら、じゃあ Go で書いて composite 使えばいいやんとかにならないのか

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant