Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement startupGracePeriod in wait-list #821

Merged
merged 60 commits into from
Jun 2, 2024
Merged

Implement startupGracePeriod in wait-list #821

merged 60 commits into from
Jun 2, 2024

Conversation

kachick
Copy link
Owner

@kachick kachick commented May 28, 2024 •
edited
Loading

Resolves #820

  • Implement core logics
  • Logging which jobs are unstarted
  • Update README
  • Update changelog
  • Add E2E tests - failed pattern is cannot be added Please support something like "allow-failure" for a given job actions/runner#2347
  • Add unit tests - need snapshot
    • Add case for missing after specified period
  • Better naming - waitForFirstValidation => marginOfStartingTime => startupGracePeriod => gracePeriod?
  • Use Temporal for duration unit, but keep current settings wait-seconds-before-first-polling and min-interval-seconds for compatibility
  • Logging current elapsed time for each polling
  • Use structured loggers for debug and develop easy

kachick added 19 commits May 29, 2024 00:35
@kachick
Rename
075a3fc
@kachick
Remove unused code
12e829c
@kachick
Add E2E CI
a50edd6
@kachick
Adjust waiting
39585e1
@kachick
Guilty of copy and paste GH-771 product
728d186
@kachick
Revert "Adjust waiting"
104e073 
This reverts commit 39585e1.
@kachick
Fix ignoring logic
6140a17
@kachick
Perfectly forgotten my codebase
c40c522
@kachick
Better CI experience
efc2703
@kachick
We can set as this
2d7b34e
@kachick
continue-on-error and no skip-list CI is a hardthing
128d789
@kachick
Revert "continue-on-error and no skip-list CI is a hardthing"
dfe854f 
This reverts commit 128d789.
@kachick
Add ugly but reasonable workaround
fbf6830
@kachick
Retire to realize whole E2E CI in PRs
a89274b
@kachick
Standardize to measure with performance API for durations
f1d6e70
@kachick
Better debug logger to get snapshots
c464691
@kachick
Temporary enable failing jobs to make snapshots
eba8002
@kachick
Clarify which job needs debug logging
e4ade4a
@kachick
Revert "Clarify which job needs debug logging"
8c14d2a 
This reverts commit e4ade4a.
kachick
kachick commented May 29, 2024
View reviewed changes
src/report.ts Outdated Show resolved Hide resolved
@kachick kachick changed the title Implement margin for first validation Implement startupGracePeriod May 29, 2024
kachick added 20 commits June 1, 2024 00:17
@kachick kachick marked this pull request as ready for review June 2, 2024 07:27
@kachick kachick changed the title Implement startupGracePeriod Implement startupGracePeriod in wait-list Jun 2, 2024
@kachick kachick merged commit 7941eac into main Jun 2, 2024
29 checks passed
@kachick kachick deleted the wait-for-validation branch June 2, 2024 07:29
@kachick kachick mentioned this pull request Jun 2, 2024
Closed
kachick added a commit that referenced this pull request Jun 2, 2024
@kachick
Add comment for adding validations for graceperiod
40238b2 
Follow #821
This was referenced Jun 2, 2024
Closed
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Question]: initial polling delay might be implemented differently
1 participant
@kachick