Skip to content

Commit

Permalink
tests: check for 2 success in external PVC type (#422)
Browse files Browse the repository at this point in the history
without the proper wait, there is a problem of trying to delete entries
before they get provisioned.

Updates: #314
Signed-off-by: Amar Tumballi <amar@kadalu.io>
  • Loading branch information
amarts committed Jan 21, 2021
1 parent d70fffe commit 06206d5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion csi/volumeutils.py
Original file line number Diff line number Diff line change
Expand Up @@ -902,7 +902,7 @@ def check_external_volume(pv_request, host_volumes):
for vol in host_volumes:
if vol["type"] != "External":
continue
if vol["g_volname"] != params["gluster_volname"]:
if vol["g_volname"] != params.get("gluster_volname", None):
continue

mntdir = os.path.join(HOSTVOL_MOUNTDIR, vol["name"])
Expand Down
2 changes: 1 addition & 1 deletion tests/minikube.sh
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ test_kadalu)

#get_pvc_and_check examples/sample-external-storage.yaml "External (PV)" 1 131

get_pvc_and_check examples/sample-external-kadalu-storage.yaml "External (Kadalu)" 1 131
get_pvc_and_check examples/sample-external-kadalu-storage.yaml "External (Kadalu)" 2 131

cp tests/storage-add.yaml /tmp/kadalu-storage.yaml
sed -i -e "s/DISK/${DISK}/g" /tmp/kadalu-storage.yaml
Expand Down

0 comments on commit 06206d5

Please sign in to comment.