Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pylint issues #61

Closed
fs-system opened this issue Nov 13, 2019 · 1 comment · Fixed by #132
Closed

Fix pylint issues #61

fs-system opened this issue Nov 13, 2019 · 1 comment · Fixed by #132
Labels
good first task Good for newcomers
Milestone
v0.5

Comments

@fs-system
Copy link

current codebase is having lint issues, need to check all modules for pylint issues in Travis CI

************* Module utils
csi/utils.py:1:0: C0111: Missing module docstring (missing-docstring)
csi/utils.py:11:0: C0103: Constant name "glusterfs_cmd" doesn't conform to UPPER_CASE naming style (invalid-name)
csi/utils.py:12:0: C0103: Constant name "info_dir" doesn't conform to UPPER_CASE naming style (invalid-name)
csi/utils.py:13:0: C0103: Constant name "volfiles_dir" doesn't conform to UPPER_CASE naming style (invalid-name)
csi/utils.py:14:0: C0103: Constant name "templates_dir" doesn't conform to UPPER_CASE naming style (invalid-name)
csi/utils.py:15:0: C0103: Constant name "reserved_size_percentage" doesn't conform to UPPER_CASE naming style (invalid-name)
csi/utils.py:20:0: C0111: Missing class docstring (missing-docstring)
csi/utils.py:24:0: C0111: Missing function docstring (missing-docstring)
csi/utils.py:28:0: C0111: Missing function docstring (missing-docstring)
csi/utils.py:29:4: C0103: Variable name "p" doesn't conform to snake_case naming style (invalid-name)
csi/utils.py:37:0: C0111: Missing function docstring (missing-docstring)
csi/utils.py:40:28: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
csi/utils.py:52:32: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
csi/utils.py:58:0: C0111: Missing function docstring (missing-docstring)
csi/utils.py:75:0: C0111: Missing function docstring (missing-docstring)
csi/utils.py:84:7: C1801: Do not use `len(SEQUENCE)` to determine if a sequence is empty (len-as-condition)
csi/utils.py:91:0: C0111: Missing function docstring (missing-docstring)
csi/utils.py:92:4: C0103: Variable name "st" doesn't conform to snake_case naming style (invalid-name)

-----------------------------------
Your code has been rated at 6.90/10
@amarts amarts added bug good first task Good for newcomers labels Nov 13, 2019
@aravindavk aravindavk mentioned this issue Dec 3, 2019
Closed
@amarts amarts added this to the v0.5 milestone Dec 31, 2019
@amarts
Copy link
Member

amarts commented Jan 16, 2020

make pylint

aravindavk added a commit that referenced this issue Jan 16, 2020
@aravindavk
Pylint Fixes
b6f069f 
`make pylint` passing now.

Fixes: #61
Signed-off-by: Aravinda Vishwanathapura <mail@aravindavk.in>
@aravindavk aravindavk mentioned this issue Jan 16, 2020
Merged
amarts pushed a commit that referenced this issue Jan 16, 2020
@aravindavk @amarts
Pylint Fixes (#132)
3c31bbc 
`make pylint` passing now.

Fixes: #61
Signed-off-by: Aravinda Vishwanathapura <mail@aravindavk.in>
@amarts amarts mentioned this issue Jan 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first task Good for newcomers
Projects
None yet
Milestone
v0.5
Development

Successfully merging a pull request may close this issue.

Pylint Fixes kadalu/kadalu
2 participants
@amarts @fs-system