Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support upgrade of pods #411

Merged
merged 1 commit into from Jan 13, 2021
Merged

Support upgrade of pods #411

merged 1 commit into from Jan 13, 2021

Conversation

amarts
Copy link
Member

@amarts amarts commented Jan 9, 2021

When the operator starts, check if config map is already present (in which case, its most probable case of upgrade). Just make sure to trigger kubectl apply on storage pods as they most probably need upgrade too.

Updates: #377 #352 and similar few
Signed-off-by: Amar Tumballi amar@kadalu.io

@amarts
Copy link
Member Author

amarts commented Jan 9, 2021

Tests pending, and hence in draft mode. Will be happy if someone tries this upgrade process locally too. (git clone the branch, build one version, now use the new version built to replace the running (test infra) instance, and you should see even the storage pods to be updated).

Signed-off-by: Amar Tumballi <amar@kadalu.io>
@amarts amarts marked this pull request as ready for review January 11, 2021 19:34
@amarts
Copy link
Member Author

amarts commented Jan 13, 2021

Did basic testing, and the upgrade is happening.

There are other issues which came up when I tested. The storage pods were not getting Terminated completely, and stayed in 'Terminating' state for more than 60secs (ie, the graceperiod), so I had to kill them manually (with kubectl delete pod -nkadalu storage-pool-pod-name), and the new pod with newer version came up.

The code to upgrade storage pods and CSI pods to latest version seems to be working fine :-)

Will merge this and continue on issues separately!

@amarts amarts merged commit df737c7 into kadalu:devel Jan 13, 2021
@amarts amarts deleted the upgrade_v1 branch January 25, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant