fix(pactjs): Fixed PactNumber to prevent the creation of scientific n…

…otation for large numbers

.changeset/little-flowers-return.md

@@ -0,0 +1,6 @@
+---
+'@kadena/pactjs': patch
+---
+
+Fixed PactNumber to prevent the creation of scientific notation for large
+numbers.

packages/libs/pactjs/package.json

@@ -42,7 +42,7 @@
     "test": "heft test"
   },
   "dependencies": {
-    "bignumber.js": "^9.0.2"
+    "bignumber.js": "^9.1.2"
   },
   "devDependencies": {
     "@kadena-dev/eslint-config": "workspace:*",

packages/libs/pactjs/src/PactNumber.ts

@@ -1,6 +1,11 @@
 /// <reference path="./extend-bignumber.ts" />
 import BigNumber from 'bignumber.js';
 
+// Configure BigNumber to prevent exponential notation (Scientific notation) for numbers.
+// The library supports a maximum of 1e9 digits, which I believe is sufficient for our use case.
+// It is highly unlikely that someone would pass a number with more than 1,000,000,000 digits.
+BigNumber.config({ EXPONENTIAL_AT: [-1e9, 1e9] });
+
 // In order to extend BigNumber methods correctly, I had to add the PactNumber methods to
 // the prototype of BigNumber. Then, something like this works:
 // const decimal = new PactNumber('0.9').plus("1").toPactDecimal()

packages/libs/pactjs/src/tests/PactNumber.test.ts

@@ -114,4 +114,27 @@ describe('Pact Number', () => {
     const pactDecimal = actual.minus('0.9').toPactDecimal();
     expect(pactDecimal).toStrictEqual({ decimal: '0.0007199254740991192919' });
   });
+
+  it('does not return scientific notation for large integer', () => {
+    const number = new PactNumber(
+      '0x584712a2542d5c1ab3cd25dec0b14e53aef270e6948140656a8fbf3d2829c729',
+    );
+    const int = number.toPactInteger();
+
+    expect(int).toEqual({
+      int: '39929105424737202205146861475763790532040240744253228361760383139526688229161',
+    });
+  });
+
+  it('does not return scientific notation for large decimals', () => {
+    const number = new PactNumber(
+      '3.9929105424737202205146861475763790532040240744253228361760383139526688229161',
+    );
+    const decimal = number.toPactDecimal();
+
+    expect(decimal).toEqual({
+      decimal:
+        '3.9929105424737202205146861475763790532040240744253228361760383139526688229161',
+    });
+  });
 });