Skip to content

Commit

Permalink
feat(kadena-cli): add bundler (#2120)
Browse files Browse the repository at this point in the history
* feat(kadena-cli): add bundler

* feat(kadena-cli): remove type definitions and definitions source map as part of bundle

* fix(kadena-cli): mock navigator once instead of in the rollup config

* fix(kadena-cli): remove undeeded dependency

---------

Co-authored-by: Bart Huijgen <barthuijgen@users.noreply.github.com>
Co-authored-by: Mohamed Ismail <ismailreality1@gmail.com>
  • Loading branch information
3 people committed May 14, 2024
1 parent 1d96ab1 commit d79818e
Show file tree
Hide file tree
Showing 6 changed files with 440 additions and 103 deletions.
6 changes: 6 additions & 0 deletions packages/tools/kadena-cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
],
"scripts": {
"build": "pnpm run generate:all && tsc",
"bundle": "rollup -c rollup.config.mjs",
"dev": "NODE_ENV=development KADENA_LOG=debug node --import @swc-node/register/esm-register src/index.ts",
"format": "pnpm run /^format:.*/",
"format:md": "remark README.md -o --use @kadena-dev/markdown",
Expand Down Expand Up @@ -78,6 +79,10 @@
"@kadena-dev/markdown": "workspace:*",
"@kadena-dev/shared-config": "workspace:*",
"@kadena/types": "workspace:*",
"@rollup/plugin-commonjs": "^25.0.7",
"@rollup/plugin-json": "^6.1.0",
"@rollup/plugin-node-resolve": "^15.2.3",
"@rollup/plugin-typescript": "^11.1.6",
"@rushstack/eslint-config": "~3.6.9",
"@rushstack/heft": "~0.50.6",
"@swc-node/register": "^1.8.0",
Expand All @@ -90,6 +95,7 @@
"eslint": "^8.45.0",
"msw": "^2.2.14",
"prettier": "~3.2.5",
"rollup": "^4.17.2",
"typescript": "5.4.5",
"vitest": "^1.1.0"
}
Expand Down
21 changes: 21 additions & 0 deletions packages/tools/kadena-cli/rollup.config.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import commonjs from '@rollup/plugin-commonjs';
import json from '@rollup/plugin-json';
import resolve from '@rollup/plugin-node-resolve';
import typescript from '@rollup/plugin-typescript';

export default {
input: 'src/index.ts',
output: {
dir: './lib',
format: 'es',
},
plugins: [
resolve(),
commonjs(),
typescript({
declaration: false,
declarationMap: false,
}),
json(),
],
};
3 changes: 3 additions & 0 deletions packages/tools/kadena-cli/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
#!/usr/bin/env node
import { readStdin } from './utils/stdin.js';

/** mock for navigator which a dependency includes in the rollup bundle */
globalThis.navigator = {} as Navigator;

async function main(): Promise<void> {
// stdin must be read before the "commander" or "chalk" packages are loaded
await readStdin();
Expand Down
2 changes: 1 addition & 1 deletion packages/tools/kadena-cli/src/utils/createOption.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export interface IOptionSettings {
export function createOption<const T extends IOptionCreatorObject>(data: T) {
return (settings?: IOptionSettings) => {
const isOptional = settings?.isOptional ?? data.defaultIsOptional ?? true;
const isInQuestions = settings?.disableQuestion !== true ?? true;
const isInQuestions = settings?.disableQuestion !== true;
// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
const prompt: T['prompt'] = (responses, args) =>
data.prompt(responses, args, isOptional);
Expand Down
1 change: 1 addition & 0 deletions packages/tools/kadena-cli/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"extends": "./node_modules/@kadena-dev/shared-config/tsconfig-base.json",
"compilerOptions": {
"outDir": "./lib",
"lib": ["ES2022"],
"module": "NodeNext",
"types": [".kadena/pactjs-generated", "./src/utils/ttys.d.ts"]
Expand Down
Loading

0 comments on commit d79818e

Please sign in to comment.