Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial rebranding and added pagination for tabs component #2061

Merged
merged 20 commits into from
May 29, 2024

Conversation

r-mulder
Copy link
Contributor

@r-mulder r-mulder commented May 3, 2024

This PR will update the tabs component to the new brand update.

Also included:

  • Pagination for the tabs list.
  • focus on active item when rendered.
  • Support scroll and pagination on all devices.

Copy link

changeset-bot bot commented May 3, 2024

🦋 Changeset detected

Latest commit: 0f41cd4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@kadena/react-ui Patch
@kadena/dev-wallet Patch
@kadena/explorer Patch
@kadena/graph-client Patch
@kadena/proof-of-us Patch
@kadena/dev-wallet-desktop Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
alpha-docs ❌ Failed (Inspect) May 29, 2024 7:55am
proof-of-us ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 7:55am
react-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 7:55am
tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 7:55am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
marmalade-marketplace ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 7:55am

@r-mulder r-mulder force-pushed the feat/ui-new-tabs-component branch from 6843bf3 to a35df5b Compare May 8, 2024 15:12
@vercel vercel bot temporarily deployed to Preview – alpha-docs May 8, 2024 15:22 Inactive
@vercel vercel bot temporarily deployed to Preview – alpha-docs May 8, 2024 15:42 Inactive
Copy link
Contributor

@eileenmguo eileenmguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the border doesn't go all the way across the tab container
image

Also, I don't see an example of pagination in storybook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants