Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statistics, Search and Logo Components (Landing Page) #2116

Merged

Conversation

nil-amrutlal-dept
Copy link
Contributor

@nil-amrutlal-dept nil-amrutlal-dept commented May 13, 2024

Desktop view
image

Mobile View
image


Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
alpha-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 8:58am
6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
dev-wallet ⬜️ Ignored (Inspect) Visit Preview Jun 3, 2024 8:58am
kadena-js-marmalade-marketplace ⬜️ Ignored (Inspect) Visit Preview Jun 3, 2024 8:58am
marmalade-marketplace ⬜️ Ignored (Inspect) Visit Preview Jun 3, 2024 8:58am
proof-of-us ⬜️ Ignored (Inspect) Visit Preview Jun 3, 2024 8:58am
react-ui ⬜️ Ignored (Inspect) Visit Preview Jun 3, 2024 8:58am
tools ⬜️ Ignored (Inspect) Visit Preview Jun 3, 2024 8:58am

Copy link

changeset-bot bot commented May 13, 2024

🦋 Changeset detected

Latest commit: 40551f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kadena/explorer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/apps/explorer/src/pages/index.tsx Outdated Show resolved Hide resolved
packages/apps/explorer/src/pages/index.tsx Outdated Show resolved Hide resolved
packages/apps/explorer/src/pages/index.tsx Outdated Show resolved Hide resolved
export const searchBoxClass = style({
...responsiveStyle({
md: {
width: 525,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the tokens from react-ui for these values

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think there are tokens with these values. And I can't seem to apply mathematical operations to the tokens (otherwise I could use a token's value and manipulate it to obtain the desired value)

packages/apps/explorer/package.json Outdated Show resolved Hide resolved
packages/apps/explorer/src/media.tsx Outdated Show resolved Hide resolved
@nil-amrutlal-dept nil-amrutlal-dept merged commit 9231982 into main Jun 3, 2024
16 checks passed
@nil-amrutlal-dept nil-amrutlal-dept deleted the feat/explorer/landing-page-and-statistics-component branch June 3, 2024 11:17
Comment on lines +54 to +55
} else if (value.length === 43) {
return 'Request Key';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe trim as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by trim? 😅


if (escapePressed || optionClicked) return;

const inferedOption = inferOption(e.target.value);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or trim here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants