chore: added hook and removed theme provider #2150
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
|
| * overwriteTheme can be used when you want 1 particular component to have a fixed theme | ||
| * IMPORTANT: this will also overwrite the lockedTheme for that component | ||
| */ | ||
| overwriteTheme?: ITheme; |
There was a problem hiding this comment.
As far as I can see, the theme is applied at the application level. How can you set it at the component level?
| /** | ||
| * lockedTheme will lock the theme for the whole application. | ||
| * It will overwrite the localstorage and even the switching of themes in your system will not update the theme | ||
| * IMPORTANT: using the useTheme twice in a application can lead to unexpected race conditions |
There was a problem hiding this comment.
But you already used the useThem twice! once in the Layout component and once in Providers which causes the issue.
I think the better way is splitting the hook to the Provider and the hook, to avoid this kind of issues.
So the setting up the theme will be handled in the Provider (So basically all useEffects)
and useTheme will be used to read/set data from/to context.
|
This will be re-done using the hook coming from react-ui lib #2137 |
following pattern from docs