Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(monorepo): add testing to pr template #2153

Merged
merged 4 commits into from
Jun 3, 2024

Conversation

alber70g
Copy link
Member

@alber70g alber70g commented May 17, 2024

To improve the quality and speed of the reviewers work, we've added a two sections to be filled when submitting a PR.

This allows us to be consious about what they're testing, and allows the reviewer to give feedback on what is tested. It also allows the reviewer to get a head start when working through the PR

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
alpha-docs ❌ Failed (Inspect) Jun 3, 2024 10:50am
dev-wallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 10:50am
kadena-js-marmalade-marketplace ❌ Failed (Inspect) Jun 3, 2024 10:50am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
marmalade-marketplace ⬜️ Ignored (Inspect) Visit Preview Jun 3, 2024 10:50am
proof-of-us ⬜️ Ignored (Inspect) Visit Preview Jun 3, 2024 10:50am
react-ui ⬜️ Ignored (Inspect) Visit Preview Jun 3, 2024 10:50am
tools ⬜️ Ignored (Inspect) Visit Preview Jun 3, 2024 10:50am

Copy link

changeset-bot bot commented May 17, 2024

⚠️ No Changeset found

Latest commit: 8a6d8c8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alber70g alber70g force-pushed the ag/chore/add-testing-to-pr-template branch from f2f6c08 to 6ce2649 Compare May 23, 2024 08:30
@alber70g alber70g force-pushed the ag/chore/add-testing-to-pr-template branch from 6ce2649 to 2585b50 Compare May 23, 2024 08:56
@alber70g alber70g force-pushed the ag/chore/add-testing-to-pr-template branch 4 times, most recently from ede6062 to d1648b8 Compare May 23, 2024 09:58
@alber70g alber70g marked this pull request as ready for review May 23, 2024 10:01
@alber70g alber70g force-pushed the ag/chore/add-testing-to-pr-template branch from d1648b8 to c91d8b1 Compare May 23, 2024 10:16
Co-authored-by: Ghislain Gabriëlse <72976986+Ghislain89@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants